NEW Form sudo mode #11582
Merged
NEW Form sudo mode #11582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
8 times, most recently
from
6750198 to
a41f2a4
Compare
emteknetnz
commented
Feb 3, 2025
emteknetnz
commented
Feb 3, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
2 times, most recently
from
426ea25 to
d9b62d4
Compare
emteknetnz
commented
Feb 3, 2025
|
|
||
| // Activate sudo mode on login so the user doesn't have to reauthenticate for sudo | ||
| // actions until the sudo mode timeout expires | ||
| $service = Injector::inst()->get(SudoModeServiceInterface::class); |
There was a problem hiding this comment.
Agreed offline that sudo mode should NOT be automatically activated when you log in
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
2 times, most recently
from
beb0526 to
40fa4ee
Compare
emteknetnz
commented
Feb 5, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
9 times, most recently
from
ae51b7f to
4bab0a8
Compare
5 tasks
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
from
4bab0a8 to
eb23b5e
Compare
GuySartorelli
requested changes
Feb 13, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
3 times, most recently
from
d14d40b to
2860c61
Compare
GuySartorelli
requested changes
Feb 17, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
3 times, most recently
from
d218c67 to
30480c3
Compare
GuySartorelli
requested changes
Feb 17, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
from
30480c3 to
eae81b5
Compare
|
#11582 (comment) still not addressed |
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
from
eae81b5 to
08f19c7
Compare
GuySartorelli
requested changes
Feb 19, 2025
GuySartorelli
requested changes
Feb 19, 2025
emteknetnz
force-pushed
the
pulls/5/form-sudo-mode
branch
from
08f19c7 to
671b1e1
Compare
Comment on lines
+583
to
+586
| if ($sudoModeTransformation) { | ||
| // Modify the GridFieldViewButton on any GridFields so that it doesn't suffix the view URL with 'view' | ||
| // This allows us to gracefully reload a form in readonly mode when sudo mode is activated | ||
| if ($item instanceof GridFieldViewButton) { |
There was a problem hiding this comment.
I'd normally ask for this to be combined into a single conditional statement but I think we're both tired of this review cycle, and the change is only a very minor code style change, so will leave as is.
GuySartorelli
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1898