Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isAdminController() logic possibly wrong #133

Open
emteknetnz opened this issue Feb 27, 2025 · 0 comments
Open

isAdminController() logic possibly wrong #133

emteknetnz opened this issue Feb 27, 2025 · 0 comments
Labels
affects/v6 type/bug

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Feb 27, 2025 •
edited by GuySartorelli
Loading

There was work done in CMS 6 the AdminController class was created to move some logic off from LeftAndMain

This means that the ErrorPageController::isAdminController() may now be out of date

Check especially for any instanceof LeftAndMain or is_a($controller, LeftAndMain::class across the sink codebase.
@emteknetnz emteknetnz changed the title isAdminController() logic possible wrong isAdminController() logic possibly wrong Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v6 type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emteknetnz