-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tree filtering in CMSMain
/HierarchyModelAdmin
#2949
Comments
This was referenced Jan 30, 2025
Merged
This was referenced Feb 11, 2025
This was referenced Feb 25, 2025
This was referenced Feb 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Form fields for filtering in
CMSMain
are hardcoded - and some of the functionality is duplicated or else needlessly different between this filter functionality andGridFieldFilterHeader
.Relevant
Acceptance Criteria
GridFieldFilterHeader
does (i.e. it usessearchableFields()
)SearchContext
is used for filtering inCMSMain
the same way it is inGridFieldFilterHeader
CMSSiteTreeFilter
logic is either made generic if possible, or else used by theSearchContext
forSiteTree
wherever filtering pages is usedCMSMain
GridFieldFilter
andCMSMain
(with the ability to use different custom templates as desired - e.g. by trying to get specific templates by class name first, and falling back to the shared one)GridFieldFilterHeader
andCMSMain
is sharedPRs
Enable
WithinRangeFilter
insearchable_fields
This set of PRs is required to match the ranged filtering against
LastEdited
which is currently only possible forSiteTree
insideCMSMain
.Avoid
filterByCallback()
inCMSSiteTreeFilter
subclassesThis set of PRs is required to migrate the
SiteTree
filtering functionality to primarily useSearchContext
, which requires filtering be done by the ORM not in PHP.Kitchen sink CI run
The main refactoring
CMS 5 PRs
Important
After merging, reassign to Guy so they can merge up and rebase the CMS 6 PRs on top
CMS 6 PRs
Kitchen sink CI run
Only remaining failure is pre-existing (see regular CMS 6 run)
The text was updated successfully, but these errors were encountered: