API Deprecate API being removed in CMS 6 #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySartorelli
force-pushed
the
pulls/2.4/deprecations
branch
2 times, most recently
from
a1ecd40 to
908e528
Compare
emteknetnz
requested changes
Feb 26, 2025
| */ | ||
| const SCHEMA_HEADER = 'X-Formschema-Request'; | ||
| const SCHEMA_HEADER = FormSchema::SCHEMA_HEADER; |
There was a problem hiding this comment.
This looks really weird, can we just keep the existing string. There's pretty much zero risk of it getting changed.
There was a problem hiding this comment.
Also shouldn't we update the CMS 5 references to this that to use the new const on FormSchema instead?
There was a problem hiding this comment.
This looks really weird, can we just keep the existing string.
I don't think it looks weird - we're setting the value to the correct constant. It's no different than when we make a deprecated method return the value of the new method.
Also shouldn't we update the CMS 5 references to this that to use the new const on FormSchema instead?
Yes, sorry, I missed that. Done.
GuySartorelli
force-pushed
the
pulls/2.4/deprecations
branch
from
908e528 to
9569779
Compare
emteknetnz
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR requires silverstripe/silverstripe-framework#11623 to be merged first, since that adds the new constant.
Issue
CMSMain/HierarchyModelAdminsilverstripe-cms#2949