Merge pull request #60 from akretion/v4.0.x-fix-steam-version

[FIX] fix erp tag linked to steam version

Author: sebastienbeau

Gemfile

@@ -4,7 +4,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 # Specify your gem's dependencies in shop_invader.gemspec
 gemspec
 
-gem 'locomotivecms_steam', github: 'akretion/steam', branch: 'better-attribute-parser'
+gem 'locomotivecms_steam', github: 'akretion/steam', branch: 'rebase-better-attribute-parser'
 gem 'faraday'
 gem 'algoliasearch'
 gem 'elasticsearch'

lib/shop_invader/liquid/tags/erp.rb

@@ -46,7 +46,7 @@ def initialize(tag_name, markup, options)
           end
 
           def render(context)
-            if @attributes
+            if @raw_attributes
               evaluate_attributes(context)
             end
             @context = context

spec/liquid/tags/erp_spec.rb

@@ -55,6 +55,14 @@
       it { is_expected.to eq '{"name"=>"SO42", "total"=>42}' }
     end
 
+    describe 'validates syntax with dynamic params and result and render it' do
+      let(:assigns) { { 'params' => Locomotive::Steam::Liquid::Drops::Params.new({ foo: 'bar' }) } }
+      let(:source)  { "{% erp get 'sale_order' as sale with foo: params.foo %}{{ sale }}" }
+      let(:params)    { ['GET', 'sale_order', {'foo': 'bar'}]}
+      it { expect { subject }.not_to raise_exception }
+      it { is_expected.to eq '{"name"=>"SO42", "total"=>42}' }
+    end
+
     describe 'raises an error if the syntax is incorrect' do
       let(:source)  { "{% erp get as sale with 42 %}{{ sale }}" }
       it { expect { subject }.to raise_exception(Liquid::SyntaxError) }