Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay Spike #9060

Closed
0xean opened this issue Mar 17, 2025 · 4 comments
Closed

Relay Spike #9060

0xean opened this issue Mar 17, 2025 · 4 comments
Assignees

Comments

@0xean
Copy link
Contributor

0xean commented Mar 17, 2025

https://docs.relay.link/what-is-relay

TLDR:

gets us a bunch of new routes (for chains we dont support yet also) and derisks lifi a bit

Spec:

https://www.notion.so/shapeshift/Relay-Link-mini-9bc4118d6fb64916985d5f0208f6c00c

Desired outputs:

  • Technical review
  • high level breakdown into tickets for implementation
  • confirm we can add affiliate fees (tim has this one for now)
@twblack88
Copy link
Contributor

Oh i found the fee bit:

appFees: Third party fees added on top of the existing fees, this fee is added by app developers and accrues offchain to minimize gas costs. the app fee payee must manually claim them later.

@NeOMakinG NeOMakinG self-assigned this Mar 19, 2025
@NeOMakinG NeOMakinG moved this from Up next / groomed to In progress in ShapeShift Dashboard Mar 19, 2025
@NeOMakinG NeOMakinG moved this from In progress to Up next / groomed in ShapeShift Dashboard Mar 20, 2025
@NeOMakinG
Copy link
Collaborator

NeOMakinG commented Mar 24, 2025

I didn't find the need to do a fully detailed spike, here are my notes:

❓ One pending question to relay team: how do we manage fees, specially when multichain (fees are supposed to be using the native token, seems like we would need to claim the fees on each chain family we are operating, that would mean 3 TXs to claim fees are we are supporting 3 different chain families with relay)

  • We might have weird behaviors because of fees, as they are supposed to use the native currency, if the user doesn't have enough of native to operate fees + gas fees, it would fail, but we need to handle those maths in our codebase (I think we do handle gas fees, but not affiliate fees included so far, this is a relay specific case I think).
    • To be implemented as specific case in validateTradeQuote

Tickets to be created:

  • Add Relay feature flag + implement getTradeQuote (which would also be getTradeRate, so let's include this in the same ticket), disable flag in production, use relay SDK to get quote
  • Implement EVM transaction handlers + checkTradeStatus
  • Implement UTXO transaction handler (only btc)
  • Implement Solana transaction handler
  • Ask for fees addresses on different chains and confirm with DFC
  • Add relay to develop and make it tested by the ops team
  • Activate Relay in production

@NeOMakinG NeOMakinG moved this from Up next / groomed to In review in ShapeShift Dashboard Mar 24, 2025
@0xApotheosis
Copy link
Member

  • Add ticket to spike on fee claiming flow for the DFC
  • Spike to ensure we can send the native token + a value using Chain Adapters, which will be necessary for collecting fees in both native and ERC20 tokens in the same TX

@NeOMakinG
Copy link
Collaborator

All tickets are created, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants