Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails in Windows #10

Open
cool-Blue opened this issue Aug 18, 2016 · 1 comment
Open

Test fails in Windows #10

cool-Blue opened this issue Aug 18, 2016 · 1 comment

Comments

@cool-Blue
Copy link

cool-Blue commented Aug 18, 2016

Very minor point but in Windows os.EOL returns '\r\n' but node writes \n so the last 2 tests fail..

// console.js#38
Console.prototype.log = function() {
  this._stdout.write(util.format.apply(null, arguments) + '\n');
};

image

I would offer a pr but I can't test on UNIX...

@sfarthin
Copy link
Owner

sfarthin commented Mar 8, 2017

Thanks, will look into this once I have a windows machine in front of me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants