You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Right now, in case of TLS, fx collaborator certify step internally registers collaborators.
This leads to confusion while running a non-TLS experiment where we need to perform collaborator registration separately as it isn't mentioned anywhere.
Git clone openfl and install all the pre-requisites.
Create workspace using fx workspace create --template torch_cnn_mnist --prefix my_workspace
Move inside my_workspace folder
Modify the plan/plan.yaml and assign use_tls: false (default value is true)
Initialise the plan.
Skip the certify steps at aggregator and collaborators level.
Create 2 collaborators - keep the names different from usual collaborator1/2 to easily identify the problem.
Run fx collaborator create -n a1 -d 1 and fx collaborator create -n a2 -d 2
At this point, plan/data.yaml gets updated with two entries a1,1 and a2,2
Start the collaborators and aggregator.
Collaborators a1 and a2 will start and keep waiting for the aggregator whereas aggregator will result in below error. ValueError: Expected sequence membership, but a2 is not in ['collaborator1', 'collaborator2']
Expected behavior
There should be a step to add/register collaborators before we create them irrespective of TLS/non TLS scenarios.
With above step in place, the experiment should run smoothly without any error.
The text was updated successfully, but these errors were encountered:
noopurintel
changed the title
Collaborator certify step internally registers collaborators, need to separate them out
Certify collaborator step internally registers it, need to separate them out
Feb 28, 2025
noopurintel
changed the title
Certify collaborator step internally registers it, need to separate them out
Certify collaborator step (in case of TLS) internally registers it, need to separate them out
Feb 28, 2025
Describe the bug
Right now, in case of TLS,
fx collaborator certify
step internally registers collaborators.This leads to confusion while running a non-TLS experiment where we need to perform collaborator registration separately as it isn't mentioned anywhere.
To Reproduce
Steps to reproduce the behavior:
fx workspace create --template torch_cnn_mnist --prefix my_workspace
my_workspace
folderplan/plan.yaml
and assignuse_tls: false
(default value is true)fx collaborator create -n a1 -d 1
andfx collaborator create -n a2 -d 2
plan/data.yaml
gets updated with two entriesa1,1
anda2,2
ValueError: Expected sequence membership, but a2 is not in ['collaborator1', 'collaborator2']
Expected behavior
The text was updated successfully, but these errors were encountered: