fix logic

Author: 0xmountaintop

core/rawdb/accessors_skipped_txs.go

@@ -181,6 +181,24 @@ func WriteSkippedTransaction(db ethdb.Database, tx *types.Transaction, traces *t
 	}
 }
 
+func ResetSkippedTransactionTracesByHash(db ethdb.Database, txHash common.Hash) {
+	mu.Lock()
+	defer mu.Unlock()
+
+	data := readSkippedTransactionRLP(db, txHash)
+	if len(data) == 0 {
+		return
+	}
+	var stx SkippedTransaction
+	if err := rlp.Decode(bytes.NewReader(data), &stx); err != nil {
+		log.Crit("Invalid skipped transaction RLP", "hash", txHash.String(), "data", data, "err", err)
+	}
+	if stx.BlockHash != nil && *stx.BlockHash == (common.Hash{}) {
+		stx.BlockHash = nil
+	}
+	writeSkippedTransaction(db, stx.Tx, nil, stx.Reason, stx.BlockNumber, stx.BlockHash)
+}
+
 // SkippedTransactionIterator is a wrapper around ethdb.Iterator that
 // allows us to iterate over skipped transaction hashes in the database.
 // It implements an interface similar to ethdb.Iterator.

eth/api.go

@@ -778,7 +778,6 @@ func (api *ScrollAPI) ResetSkippedTransactionsTraces(ctx context.Context, from u
 }
 
 func (api *ScrollAPI) ResetSkippedTransactionTracesByHash(ctx context.Context, hash common.Hash) error {
-	stx := rawdb.ReadSkippedTransaction(api.eth.ChainDb(), hash)
-	rawdb.WriteSkippedTransaction(api.eth.ChainDb(), stx.Tx, nil, stx.Reason, stx.BlockNumber, stx.BlockHash)
+	rawdb.ResetSkippedTransactionTracesByHash(api.eth.ChainDb(), hash)
 	return nil
 }