address comments

Author: 0xmountaintop

core/rawdb/accessors_skipped_txs.go

@@ -182,20 +182,7 @@ func WriteSkippedTransaction(db ethdb.Database, tx *types.Transaction, traces *t
 }
 
 func ResetSkippedTransactionTracesByHash(db ethdb.Database, txHash common.Hash) {
-	mu.Lock()
-	defer mu.Unlock()
-
-	data := readSkippedTransactionRLP(db, txHash)
-	if len(data) == 0 {
-		return
-	}
-	var stx SkippedTransaction
-	if err := rlp.Decode(bytes.NewReader(data), &stx); err != nil {
-		log.Crit("Invalid skipped transaction RLP", "hash", txHash.String(), "data", data, "err", err)
-	}
-	if stx.BlockHash != nil && *stx.BlockHash == (common.Hash{}) {
-		stx.BlockHash = nil
-	}
+	stx := ReadSkippedTransaction(db, txHash)
 	writeSkippedTransaction(db, stx.Tx, nil, stx.Reason, stx.BlockNumber, stx.BlockHash)
 }
 

eth/api.go

@@ -762,7 +762,7 @@ func (api *ScrollAPI) GetSkippedTransactionHashes(ctx context.Context, from uint
 	return hashes, nil
 }
 
-// ResetSkippedTransactionsTraces reset the traces for skipped txs stored in db, and returns the list of reset transaction hashes.
+// ResetSkippedTransactionsTraces resets the traces for skipped txs stored in db, and returns the list of reset transaction hashes.
 // The skipped txs to reset are specified by the two indices provided (inclusive).
 func (api *ScrollAPI) ResetSkippedTransactionsTraces(ctx context.Context, from uint64, to uint64) ([]common.Hash, error) {
 	hashes, err := api.GetSkippedTransactionHashes(ctx, from, to)