Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in fieldnames list #281

Open
matthewfeickert opened this issue Feb 3, 2025 · 1 comment
Open

Bug in fieldnames list #281

matthewfeickert opened this issue Feb 3, 2025 · 1 comment
Labels

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 3, 2025

Woops. Looks like there's a bug here

fieldnames = ["initInfo", "procInfo" "weightgroup", "LHEVersion"]

as of PR #233.

We should add a test to catch this and make a patch release.

cc @APN-Pucky @eduardo-rodrigues

Originally posted by @matthewfeickert in #280 (comment)

@APN-Pucky
Copy link
Member

@matthewfeickert Yes, it should be fixed, but does it have any implications? I think not since tests passed using the self["weightgroup"] dict way. I know that the __all__ variable is tested somehow (either pre-commit or ci).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants