Skip to content

Commit 5425b28

Browse files
hotzenklotzphilippotto
hotzenklotz
and
philippotto
authored
Update Biome to v1.8 (#8036)
* updated biome to v1.8 * foo * fromating? * fixed remaing biome errors * format package.json with two spaces * Update frontend/javascripts/oxalis/controller.tsx Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com> --------- Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
1 parent 31ecd65 commit 5425b28

File tree

333 files changed

+1309
-1148
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

333 files changed

+1309
-1148
lines changed

‎biome.json

+9-1
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,13 @@
8888
"libs/trackball_controls.ts",
8989
"*.d.ts"
9090
]
91-
}
91+
},
92+
"overrides": [
93+
{
94+
"include": ["**/package.json"],
95+
"formatter": {
96+
"lineWidth": 1
97+
}
98+
}
99+
]
92100
}

‎frontend/javascripts/admin/admin_rest_api.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,13 @@ import Toast from "libs/toast";
9797
import * as Utils from "libs/utils";
9898
import messages from "messages";
9999
import window, { location } from "libs/window";
100-
import { SaveQueueType } from "oxalis/model/actions/save_actions";
101-
import { DatasourceConfiguration } from "types/schemas/datasource.types";
100+
import type { SaveQueueType } from "oxalis/model/actions/save_actions";
101+
import type { DatasourceConfiguration } from "types/schemas/datasource.types";
102102
import { doWithToken } from "./api/token";
103-
import BoundingBox from "oxalis/model/bucket_data_handling/bounding_box";
104-
import { ArbitraryObject } from "types/globals";
103+
import type BoundingBox from "oxalis/model/bucket_data_handling/bounding_box";
104+
import type { ArbitraryObject } from "types/globals";
105105
import { assertResponseLimit } from "./api/api_utils";
106-
import { AnnotationTypeFilterEnum } from "admin/statistic/project_and_annotation_type_dropdown";
106+
import type { AnnotationTypeFilterEnum } from "admin/statistic/project_and_annotation_type_dropdown";
107107

108108
export * from "./api/token";
109109
export * from "./api/jobs";

‎frontend/javascripts/admin/api/folders.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Request from "libs/request";
2-
import { Folder, FlatFolderTreeItem, FolderUpdater } from "types/api_flow_types";
2+
import type { Folder, FlatFolderTreeItem, FolderUpdater } from "types/api_flow_types";
33

44
export function getFolder(folderId: string): Promise<Folder> {
55
return Request.receiveJSON(`/api/folders/${folderId}`);

‎frontend/javascripts/admin/api/mesh.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import Request from "libs/request";
22
import _ from "lodash";
3-
import { Vector3, Vector4 } from "oxalis/constants";
4-
import { APIDatasetId } from "types/api_flow_types";
3+
import type { Vector3, Vector4 } from "oxalis/constants";
4+
import type { APIDatasetId } from "types/api_flow_types";
55
import { doWithToken } from "./token";
66

77
export type MeshChunk = {

‎frontend/javascripts/admin/auth/change_password_view.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from "react";
2-
import { RouteComponentProps, withRouter } from "react-router-dom";
2+
import { type RouteComponentProps, withRouter } from "react-router-dom";
33
import { Form, Input, Button, Col, Row, Alert } from "antd";
44
import { LockOutlined } from "@ant-design/icons";
55
import Request from "libs/request";

‎frontend/javascripts/admin/auth/finish_reset_password_view.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from "react";
2-
import { RouteComponentProps, withRouter } from "react-router-dom";
2+
import { type RouteComponentProps, withRouter } from "react-router-dom";
33
import { Form, Input, Button, Col, Row, Card } from "antd";
44
import { LockOutlined } from "@ant-design/icons";
55
import Request from "libs/request";

‎frontend/javascripts/admin/auth/registration_view.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { getDefaultOrganization } from "admin/admin_rest_api";
77
import features from "features";
88
import RegistrationFormWKOrg from "admin/auth/registration_form_wkorg";
99
import RegistrationFormGeneric from "admin/auth/registration_form_generic";
10-
import { APIOrganization } from "types/api_flow_types";
10+
import type { APIOrganization } from "types/api_flow_types";
1111

1212
function RegistrationViewGeneric() {
1313
const history = useHistory();

‎frontend/javascripts/admin/auth/start_reset_password_view.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from "react";
2-
import { Link, RouteComponentProps, withRouter } from "react-router-dom";
2+
import { Link, type RouteComponentProps, withRouter } from "react-router-dom";
33
import { Form, Input, Button, Col, Row, Card } from "antd";
44
import { MailOutlined } from "@ant-design/icons";
55
import Request from "libs/request";

‎frontend/javascripts/admin/auth/verify_email_view.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React, { useEffect } from "react";
33
import { useFetch } from "libs/react_helpers";
44
import { requestVerificationMail, verifyEmail } from "admin/admin_rest_api";
55
import Toast from "libs/toast";
6-
import { ServerErrorMessage } from "libs/request";
6+
import type { ServerErrorMessage } from "libs/request";
77
import { useHistory } from "react-router-dom";
88
import { Store } from "oxalis/singletons";
99

‎frontend/javascripts/admin/dataset/composition_wizard/01_select_import_type.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { Button, Radio, RadioChangeEvent, Space } from "antd";
1+
import { Button, Radio, type RadioChangeEvent, Space } from "antd";
22
import React from "react";
3-
import { WizardComponentProps } from "./common";
3+
import type { WizardComponentProps } from "./common";
44

55
export default function SelectImportType({
66
wizardContext,

‎frontend/javascripts/admin/dataset/composition_wizard/02_upload_files.tsx

+10-5
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,20 @@
11
import { FileExcelOutlined } from "@ant-design/icons";
22
import { Button, Upload } from "antd";
3-
import { UploadChangeParam, UploadFile } from "antd/lib/upload";
3+
import type { UploadChangeParam, UploadFile } from "antd/lib/upload";
44
import { AsyncButton } from "components/async_clickables";
55
import { readFileAsText } from "libs/read_file";
66
import Toast from "libs/toast";
77
import { SoftError } from "libs/utils";
88
import _ from "lodash";
9-
import { Vector3 } from "oxalis/constants";
9+
import type { Vector3 } from "oxalis/constants";
1010
import { parseNml } from "oxalis/model/helpers/nml_helpers";
1111
import React from "react";
12-
import { tryToFetchDatasetsByName, WizardComponentProps, WizardContext, FileList } from "./common";
12+
import {
13+
tryToFetchDatasetsByName,
14+
type WizardComponentProps,
15+
type WizardContext,
16+
type FileList,
17+
} from "./common";
1318
import ErrorHandling from "libs/error_handling";
1419
import * as Utils from "libs/utils";
1520

@@ -133,8 +138,8 @@ async function parseBigWarpFile(fileList: FileList): Promise<Partial<WizardConte
133138
const [_pointName, enabled, x1, y1, z1, x2, y2, z2] = fields;
134139

135140
if (enabled) {
136-
const source = [x1, y1, z1].map((el) => parseInt(el.replaceAll('"', ""))) as Vector3;
137-
const target = [x2, y2, z2].map((el) => parseInt(el.replaceAll('"', ""))) as Vector3;
141+
const source = [x1, y1, z1].map((el) => Number.parseInt(el.replaceAll('"', ""))) as Vector3;
142+
const target = [x2, y2, z2].map((el) => Number.parseInt(el.replaceAll('"', ""))) as Vector3;
138143
sourcePoints.push(source);
139144
targetPoints.push(target);
140145
}

‎frontend/javascripts/admin/dataset/composition_wizard/03_select_datasets.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { Button } from "antd";
22
import { AsyncButton } from "components/async_clickables";
33
import DatasetSelectionComponent, {
4-
DatasetSelectionValue,
4+
type DatasetSelectionValue,
55
} from "dashboard/dataset/dataset_selection_component";
66
import React, { useState } from "react";
7-
import { tryToFetchDatasetsByName, WizardComponentProps } from "./common";
7+
import { tryToFetchDatasetsByName, type WizardComponentProps } from "./common";
88
import { useEffectOnlyOnce } from "libs/react_hooks";
99

1010
export default function SelectDatasets({ wizardContext, setWizardContext }: WizardComponentProps) {

‎frontend/javascripts/admin/dataset/composition_wizard/04_configure_new_dataset.tsx

+20-9
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,18 @@ import {
55
DatasetNameFormItem,
66
layerNameRules,
77
} from "admin/dataset/dataset_components";
8-
import { Button, Checkbox, Col, Form, FormInstance, Input, List, Modal, Row, Tooltip } from "antd";
8+
import {
9+
Button,
10+
Checkbox,
11+
Col,
12+
Form,
13+
type FormInstance,
14+
Input,
15+
List,
16+
Modal,
17+
Row,
18+
Tooltip,
19+
} from "antd";
920
import { FormItemWithInfo } from "dashboard/dataset/helper_components";
1021
import FolderSelection from "dashboard/folders/folder_selection";
1122
import { estimateAffineMatrix4x4 } from "libs/estimate_affine";
@@ -14,23 +25,23 @@ import * as Utils from "libs/utils";
1425
import _ from "lodash";
1526
import messages from "messages";
1627
import { flatToNestedMatrix } from "oxalis/model/accessors/dataset_accessor";
17-
import { OxalisState } from "oxalis/store";
28+
import type { OxalisState } from "oxalis/store";
1829
import React, { useState } from "react";
1930
import { useSelector } from "react-redux";
2031
import {
21-
APIDataLayer,
22-
APIDataset,
23-
APIDatasetId,
24-
APITeam,
32+
type APIDataLayer,
33+
type APIDataset,
34+
type APIDatasetId,
35+
type APITeam,
2536
areDatasetsIdentical,
26-
LayerLink,
37+
type LayerLink,
2738
} from "types/api_flow_types";
2839
import { syncValidator } from "types/validation";
29-
import { WizardComponentProps } from "./common";
40+
import type { WizardComponentProps } from "./common";
3041
import { useEffectOnlyOnce } from "libs/react_hooks";
3142
import { formatNumber } from "libs/format_utils";
3243
import { checkLandmarksForThinPlateSpline } from "oxalis/model/helpers/transformation_helpers";
33-
import { Vector3 } from "oxalis/constants";
44+
import type { Vector3 } from "oxalis/constants";
3445
import { WkDevFlags } from "oxalis/api/wk_dev";
3546

3647
const FormItem = Form.Item;

‎frontend/javascripts/admin/dataset/composition_wizard/common.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { getDataset } from "admin/admin_rest_api";
2-
import { UploadFile } from "antd";
2+
import type { UploadFile } from "antd";
33
import Toast from "libs/toast";
4-
import { Vector3 } from "oxalis/constants";
4+
import type { Vector3 } from "oxalis/constants";
55
import { Store } from "oxalis/singletons";
6-
import { APIDataset, APIDataStore } from "types/api_flow_types";
6+
import type { APIDataset, APIDataStore } from "types/api_flow_types";
77

88
export type FileList = UploadFile<any>[];
99

‎frontend/javascripts/admin/dataset/dataset_add_compose_view.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { CardContainer } from "admin/dataset/dataset_components";
22
import React, { useState } from "react";
3-
import { APIDataStore } from "types/api_flow_types";
3+
import type { APIDataStore } from "types/api_flow_types";
44
import SelectImportType from "./composition_wizard/01_select_import_type";
55
import UploadFiles from "./composition_wizard/02_upload_files";
66
import SelectDatasets from "./composition_wizard/03_select_datasets";
77
import { ConfigureNewDataset } from "./composition_wizard/04_configure_new_dataset";
8-
import { WizardComponentProps, WizardContext } from "./composition_wizard/common";
8+
import type { WizardComponentProps, WizardContext } from "./composition_wizard/common";
99

1010
type Props = {
1111
onAdded: WizardComponentProps["onAdded"];

‎frontend/javascripts/admin/dataset/dataset_add_remote_view.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
Radio,
77
Row,
88
Collapse,
9-
FormInstance,
9+
type FormInstance,
1010
Modal,
1111
Divider,
1212
List,
@@ -25,19 +25,19 @@ import Toast from "libs/toast";
2525
import _ from "lodash";
2626
import { Hint } from "oxalis/view/action-bar/download_modal_view";
2727
import { formatScale } from "libs/format_utils";
28-
import { DataLayer, DatasourceConfiguration } from "types/schemas/datasource.types";
28+
import type { DataLayer, DatasourceConfiguration } from "types/schemas/datasource.types";
2929
import DatasetSettingsDataTab, {
3030
// Sync simple with advanced and get newest datasourceJson
3131
syncDataSourceFields,
3232
} from "dashboard/dataset/dataset_settings_data_tab";
3333
import { FormItemWithInfo, Hideable } from "dashboard/dataset/helper_components";
3434
import FolderSelection from "dashboard/folders/folder_selection";
35-
import { RcFile, UploadChangeParam, UploadFile } from "antd/lib/upload";
35+
import type { RcFile, UploadChangeParam, UploadFile } from "antd/lib/upload";
3636
import { UnlockOutlined } from "@ant-design/icons";
3737
import { Unicode } from "oxalis/constants";
3838
import { readFileAsText } from "libs/read_file";
3939
import * as Utils from "libs/utils";
40-
import { ArbitraryObject } from "types/globals";
40+
import type { ArbitraryObject } from "types/globals";
4141
import BrainSpinner from "components/brain_spinner";
4242
import { useHistory } from "react-router-dom";
4343

‎frontend/javascripts/admin/dataset/dataset_add_view.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { RouteComponentProps } from "react-router-dom";
22
import { withRouter } from "react-router-dom";
3-
import { Tabs, Modal, Button, Layout, TabsProps } from "antd";
3+
import { Tabs, Modal, Button, Layout, type TabsProps } from "antd";
44
import { CopyOutlined, DatabaseOutlined, UploadOutlined } from "@ant-design/icons";
55
import React, { useState } from "react";
66
import { connect, useSelector } from "react-redux";
@@ -13,7 +13,7 @@ import features from "features";
1313
import { getDatastores } from "admin/admin_rest_api";
1414
import { useFetch } from "libs/react_helpers";
1515
import DatasetAddComposeView from "./dataset_add_compose_view";
16-
import { History } from "history";
16+
import type { History } from "history";
1717

1818
const { Content, Sider } = Layout;
1919

‎frontend/javascripts/admin/dataset/dataset_components.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import * as React from "react";
2-
import { Form, Input, Select, Card, FormInstance } from "antd";
1+
import type * as React from "react";
2+
import { Form, Input, Select, Card, type FormInstance } from "antd";
33
import messages from "messages";
44
import { isDatasetNameValid } from "admin/admin_rest_api";
55
import type { APIDataStore, APITeam, APIUser } from "types/api_flow_types";

‎frontend/javascripts/admin/dataset/dataset_upload_view.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
Select,
1414
Tooltip,
1515
} from "antd";
16-
import { Location as HistoryLocation, Action as HistoryAction } from "history";
16+
import type { Location as HistoryLocation, Action as HistoryAction } from "history";
1717
import {
1818
InfoCircleOutlined,
1919
FileOutlined,
@@ -27,9 +27,9 @@ import dayjs from "dayjs";
2727

2828
import classnames from "classnames";
2929
import _ from "lodash";
30-
import { useDropzone, FileWithPath } from "react-dropzone";
30+
import { useDropzone, type FileWithPath } from "react-dropzone";
3131
import ErrorHandling from "libs/error_handling";
32-
import { Link, RouteComponentProps } from "react-router-dom";
32+
import { Link, type RouteComponentProps } from "react-router-dom";
3333
import { withRouter } from "react-router-dom";
3434
import {
3535
type APITeam,
@@ -49,7 +49,7 @@ import {
4949
sendAnalyticsEvent,
5050
sendFailedRequestAnalyticsEvent,
5151
getUnfinishedUploads,
52-
UnfinishedUpload,
52+
type UnfinishedUpload,
5353
} from "admin/admin_rest_api";
5454
import Toast from "libs/toast";
5555
import * as Utils from "libs/utils";
@@ -65,7 +65,7 @@ import {
6565
import { Vector3Input } from "libs/vector_input";
6666
import features from "features";
6767
import { syncValidator } from "types/validation";
68-
import { FormInstance } from "antd/lib/form";
68+
import type { FormInstance } from "antd/lib/form";
6969
import { AllUnits, UnitLong, LongUnitToShortUnitMap, type Vector3 } from "oxalis/constants";
7070
import { FormItemWithInfo, confirmAsync } from "../../dashboard/dataset/helper_components";
7171
import FolderSelection from "dashboard/folders/folder_selection";

‎frontend/javascripts/admin/job/job_hooks.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import features from "features";
22
import { getJob, getJobs } from "admin/admin_rest_api";
33
import { useState } from "react";
4-
import { APIJob } from "types/api_flow_types";
4+
import type { APIJob } from "types/api_flow_types";
55
import { useEffectOnlyOnce, usePolling } from "libs/react_hooks";
66

77
type JobInfo = [jobKey: string, jobId: string];

‎frontend/javascripts/admin/job/job_list_view.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import {
1414
QuestionCircleTwoTone,
1515
InfoCircleOutlined,
1616
} from "@ant-design/icons";
17-
import * as React from "react";
18-
import { APIJob, APIJobType } from "types/api_flow_types";
17+
import type * as React from "react";
18+
import { type APIJob, APIJobType } from "types/api_flow_types";
1919
import { getJobs, cancelJob } from "admin/admin_rest_api";
2020
import Persistence from "libs/persistence";
2121
import * as Utils from "libs/utils";

‎frontend/javascripts/admin/onboarding.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
PlusOutlined,
1515
UserAddOutlined,
1616
} from "@ant-design/icons";
17-
import { Link, RouteComponentProps, withRouter } from "react-router-dom";
17+
import { Link, type RouteComponentProps, withRouter } from "react-router-dom";
1818
import { connect } from "react-redux";
1919
import type { APIUser, APIDataStore } from "types/api_flow_types";
2020
import type { OxalisState } from "oxalis/store";

‎frontend/javascripts/admin/organization/organization_cards.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ import { Alert, Button, Card, Col, Progress, Row } from "antd";
88
import { formatDateInLocalTimeZone } from "components/formatted_date";
99
import dayjs from "dayjs";
1010
import Constants from "oxalis/constants";
11-
import { OxalisState } from "oxalis/store";
12-
import React from "react";
11+
import type { OxalisState } from "oxalis/store";
12+
import type React from "react";
1313
import { useSelector } from "react-redux";
14-
import { APIOrganization } from "types/api_flow_types";
14+
import type { APIOrganization } from "types/api_flow_types";
1515
import {
1616
hasPricingPlanExceededStorage,
1717
hasPricingPlanExceededUsers,
@@ -38,7 +38,7 @@ export function TeamAndPowerPlanUpgradeCards({
3838
title={`${PricingPlanEnum.Team} Plan`}
3939
styles={{ body: { minHeight: 220, opacity: 0.8 } }}
4040
actions={[
41-
<Button type="primary" onClick={teamUpgradeCallback}>
41+
<Button type="primary" onClick={teamUpgradeCallback} key="buy-teamupgrade-button">
4242
<PlusCircleOutlined /> Buy Upgrade
4343
</Button>,
4444
]}
@@ -55,7 +55,7 @@ export function TeamAndPowerPlanUpgradeCards({
5555
title={`${PricingPlanEnum.Power} Plan`}
5656
styles={{ body: { minHeight: 220, opacity: 0.8 } }}
5757
actions={[
58-
<Button type="primary" onClick={powerUpgradeCallback}>
58+
<Button type="primary" onClick={powerUpgradeCallback} key="buy-power-upgrade-button">
5959
<PlusCircleOutlined /> Buy Upgrade
6060
</Button>,
6161
]}

‎frontend/javascripts/admin/organization/organization_edit_view.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
getPricingPlanStatus,
1818
} from "admin/admin_rest_api";
1919
import Toast from "libs/toast";
20-
import { APIOrganization, APIPricingPlanStatus } from "types/api_flow_types";
20+
import type { APIOrganization, APIPricingPlanStatus } from "types/api_flow_types";
2121
import {
2222
PlanAboutToExceedAlert,
2323
PlanDashboardCard,

‎frontend/javascripts/admin/organization/pricing_plan_utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import messages from "messages";
2-
import { APIOrganization, APIUser } from "types/api_flow_types";
2+
import type { APIOrganization, APIUser } from "types/api_flow_types";
33

44
export enum PricingPlanEnum {
55
Basic = "Basic",

0 commit comments

Comments
 (0)