MDL-84323 core_badges: Remove endorsement from JSON

The endorsement has been removed from the JSON because, according to
the OBv2.0specification, it must not be included in either the badge
or the assertion.
Including it results in a format error, rendering the badge invalid.

Author: sarjona

badges/badge_json.php

@@ -95,12 +95,6 @@
              $json['related'] = $relateds;
         }
 
-        $endorsement = $badge->get_endorsement();
-        if (!empty($endorsement)) {
-            $endorsementurl = new moodle_url('/badges/endorsement_json.php', array('id' => $badge->id));
-            $json['endorsement'] = $endorsementurl->out(false);
-        }
-
         $alignments = $badge->get_alignments();
         if (!empty($alignments)) {
             foreach ($alignments as $item) {

badges/classes/assertion.php

@@ -357,10 +357,6 @@ protected function embed_data_badge_version2(&$json, $type = OPEN_BADGES_V2_TYPE
                 if (!empty($relatedbadges = $this->get_related_badges($badge))) {
                     $json['related'] = $relatedbadges;
                 }
-                if ($endorsement = $this->get_endorsement()) {
-                    $endorsementurl = new moodle_url('/badges/endorsement_json.php', array('id' => $this->_data->id));
-                    $json['endorsement'] = $endorsementurl->out(false);
-                }
                 if ($alignments = $this->get_alignments()) {
                     $json['alignments'] = $alignments;
                 }

badges/tests/classes/badges_testcase.php

@@ -166,7 +166,7 @@ protected function setUp(): void {
             '"criteria":{"id":"%s","narrative":"%s"},"issuer":{"name":"%s","url":"%s","email":"%s",' .
             '"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"Issuer"},' .
             '"tags":%s,"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"BadgeClass","version":"%s",' .
-            '"@language":"en","related":[{"id":"%s","version":"%s","@language":"%s"}],"endorsement":"%s",' .
+            '"@language":"en","related":[{"id":"%s","version":"%s","@language":"%s"}],' .
             '"alignments":[{"targetName":"%s","targetUrl":"%s","targetDescription":"%s","targetFramework":"%s",' .
             '"targetCode":"%s"}]},"verify":{"type":"hosted","url":"%s"},"issuedOn":"%s","evidence":"%s","tags":%s,' .
             '"@context":"https:\/\/w3id.org\/openbadges\/v2","type":"Assertion","id":"%s"}';
@@ -175,7 +175,7 @@ protected function setUp(): void {
             '"criteria":{"id":"%s","narrative":"%s"},"issuer":{"name":"%s","url":"%s","email":"%s",' .
             '"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"Issuer"},' .
             '"tags":%s,"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"BadgeClass","version":"%s",' .
-            '"@language":"%s","related":[{"id":"%s","version":"%s","@language":"%s"}],"endorsement":"%s",' .
+            '"@language":"%s","related":[{"id":"%s","version":"%s","@language":"%s"}],' .
             '"alignments":[{"targetName":"%s","targetUrl":"%s","targetDescription":"%s","targetFramework":"%s",' .
             '"targetCode":"%s"}]}';
         $this->assertion2->issuer = '{"name":"%s","url":"%s","email":"%s",' .