MDL-83905 core_badges: Replace manual JSON with exporters

Author: sarjona

badges/classes/assertion.php

@@ -28,6 +28,8 @@
 require_once($CFG->libdir . '/badgeslib.php');
 require_once($CFG->dirroot . '/badges/renderer.php');
 
+use core_badges\local\backpack\ob\exporter_base;
+
 /**
  * Class that represents badge assertion.
  *
@@ -116,6 +118,13 @@ public function get_assertion_hash() {
      * @return array Badge assertion.
      */
     public function get_badge_assertion($issued = true, $usesalt = true) {
+        $assertionexporter = exporter_base::create_assertion_exporter_from_hash(
+            $this->_data->uniquehash,
+            exporter_base::convert_apiversion(OPEN_BADGES_V2),
+        );
+        return $assertionexporter->export();
+
+/*
         global $CFG;
         $assertion = array();
         if ($this->_data) {
@@ -163,6 +172,7 @@ public function get_badge_assertion($issued = true, $usesalt = true) {
             $this->embed_data_badge_version2($assertion, OPEN_BADGES_V2_TYPE_ASSERTION);
         }
         return $assertion;
+*/
     }
 
     /**
@@ -172,6 +182,14 @@ public function get_badge_assertion($issued = true, $usesalt = true) {
      * @return array Badge Class information.
      */
     public function get_badge_class($issued = true) {
+        // TODO: Should the image be added with the data:image/png;base64, prefix?
+        $badgeexporter = exporter_base::create_badge_exporter_from_id(
+            $this->get_badge_id(),
+            exporter_base::convert_apiversion(OPEN_BADGES_V2),
+        );
+        return $badgeexporter->export();
+/*
+// TODO: This badge contains less information, for instance, version or language are not present).
         $class = [];
         if ($this->_data) {
             if (empty($this->_data->courseid)) {
@@ -214,6 +232,7 @@ public function get_badge_class($issued = true) {
             }
         }
         return $class;
+*/
     }
 
     /**
@@ -222,11 +241,11 @@ public function get_badge_class($issued = true) {
      * @return array Issuer information.
      */
     public function get_issuer() {
-        $badge = new badge($this->get_badge_id());
-        $issuer = $badge->get_badge_issuer();
-
-        $this->embed_data_badge_version2($issuer, OPEN_BADGES_V2_TYPE_ISSUER);
-        return $issuer;
+        $issuerexporter = exporter_base::create_issuer_exporter_from_id(
+            $this->get_badge_id(),
+            exporter_base::convert_apiversion(OPEN_BADGES_V2),
+        );
+        return $issuerexporter->export();
     }
 
     /**
@@ -236,6 +255,13 @@ public function get_issuer() {
      * @return array|bool List related badges.
      */
     public function get_related_badges(badge $badge) {
+        $badgeexporter = exporter_base::create_badge_exporter_from_id(
+            $badge->id,
+            exporter_base::convert_apiversion(OPEN_BADGES_V2),
+        );
+        return $badgeexporter->export_related_badges();
+
+        /*
         global $DB;
         $arraybadges = array();
         $relatedbadges = $badge->get_related_badges(true);
@@ -250,6 +276,7 @@ public function get_related_badges(badge $badge) {
             }
         }
         return $arraybadges;
+        */
     }
 
     /**
@@ -270,6 +297,13 @@ public function get_endorsement() {
      * @return array|string Criteria information.
      */
     public function get_criteria_badge_class() {
+        $badgeexporter = exporter_base::create_badge_exporter_from_id(
+            $this->get_badge_id(),
+            exporter_base::convert_apiversion(OPEN_BADGES_V2),
+        );
+        return $badgeexporter->export_criteria();
+
+/*
         $badge = new badge($this->_data->id);
         $narrative = $badge->markdown_badge_criteria();
         $params = ['id' => $this->get_badge_id()];
@@ -282,6 +316,7 @@ public function get_criteria_badge_class() {
         } else {
             return $badgeurl->out(false);
         }
+*/
     }
 
     /**
@@ -290,6 +325,13 @@ public function get_criteria_badge_class() {
      * @return array information.
      */
     public function get_alignments() {
+        $badgeexporter = exporter_base::create_badge_exporter_from_id(
+            $this->get_badge_id(),
+            exporter_base::convert_apiversion(OPEN_BADGES_V2),
+        );
+        return $badgeexporter->export_alignments();
+
+        /*
         global $DB;
         $badgeid = $this->_data->id;
         $alignments = array();
@@ -308,6 +350,7 @@ public function get_alignments() {
             $alignments[] = $alignment;
         }
         return $alignments;
+        */
     }
 
     /**

badges/classes/badge.php

@@ -16,6 +16,8 @@
 
 namespace core_badges;
 
+use core_badges\local\backpack\ob\exporter_base;
+
 defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->dirroot.'/lib/badgeslib.php');
@@ -946,6 +948,12 @@ public function markdown_badge_criteria() {
      * @return array Issuer informations of the badge.
      */
     public function get_badge_issuer(?int $obversion = null) {
+        $issuerexporter = exporter_base::create_issuer_exporter_from_id(
+            $this->id,
+            exporter_base::convert_apiversion($obversion),
+        );
+        return $issuerexporter->export();
+/*
         return [
             'name' => $this->issuername,
             'url' => $this->issuerurl,
@@ -954,6 +962,7 @@ public function get_badge_issuer(?int $obversion = null) {
             'id' => (new moodle_url('/badges/issuer_json.php', ['id' => $this->id]))->out(false),
             'type' => OPEN_BADGES_V2_TYPE_ISSUER,
         ];
+*/
     }
 
     /**