From 34ee28928ec21f76290c935faf6b6296252d2c30 Mon Sep 17 00:00:00 2001 From: Yan Date: Mon, 13 Nov 2023 10:16:25 +0800 Subject: [PATCH 1/2] fix b/1121 --- just_audio_web/lib/just_audio_web.dart | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/just_audio_web/lib/just_audio_web.dart b/just_audio_web/lib/just_audio_web.dart index a98402a92..48d78ceae 100644 --- a/just_audio_web/lib/just_audio_web.dart +++ b/just_audio_web/lib/just_audio_web.dart @@ -961,10 +961,15 @@ class _PlayPauseQueue { Future _run() async { await for (var request in _queue.stream) { - if (request.playing) { - await audioElement.play(); - } else { - audioElement.pause(); + try { + if (request.playing) { + await audioElement.play(); + } else { + audioElement.pause(); + } + } catch (err) { + request.completer.completeError(err); + continue; } request.completer.complete(); } From ed742803f05ee382e043d1b634e0dd51e08f2ea7 Mon Sep 17 00:00:00 2001 From: Ryan Heise Date: Mon, 13 Nov 2023 18:45:43 +1100 Subject: [PATCH 2/2] Clean up, version bump, CHANGELOG. --- just_audio/pubspec.yaml | 2 +- just_audio_web/CHANGELOG.md | 4 ++++ just_audio_web/lib/just_audio_web.dart | 7 +++---- just_audio_web/pubspec.yaml | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/just_audio/pubspec.yaml b/just_audio/pubspec.yaml index 5d41e1248..1371cef96 100644 --- a/just_audio/pubspec.yaml +++ b/just_audio/pubspec.yaml @@ -17,7 +17,7 @@ dependencies: just_audio_platform_interface: ^4.2.2 # just_audio_platform_interface: # path: ../just_audio_platform_interface - just_audio_web: ^0.4.8 + just_audio_web: ^0.4.9 # just_audio_web: # path: ../just_audio_web audio_session: ^0.1.14 diff --git a/just_audio_web/CHANGELOG.md b/just_audio_web/CHANGELOG.md index 2573c6218..4038b0d12 100644 --- a/just_audio_web/CHANGELOG.md +++ b/just_audio_web/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.4.9 + +* Fix bug to ensure play exceptions pass through (@idy). + ## 0.4.8 * Update minimum flutter version to 3.0. diff --git a/just_audio_web/lib/just_audio_web.dart b/just_audio_web/lib/just_audio_web.dart index 48d78ceae..f55f16234 100644 --- a/just_audio_web/lib/just_audio_web.dart +++ b/just_audio_web/lib/just_audio_web.dart @@ -967,11 +967,10 @@ class _PlayPauseQueue { } else { audioElement.pause(); } - } catch (err) { - request.completer.completeError(err); - continue; + request.completer.complete(); + } catch (e, st) { + request.completer.completeError(e, st); } - request.completer.complete(); } } } diff --git a/just_audio_web/pubspec.yaml b/just_audio_web/pubspec.yaml index bb096d9b0..ea92024af 100644 --- a/just_audio_web/pubspec.yaml +++ b/just_audio_web/pubspec.yaml @@ -1,7 +1,7 @@ name: just_audio_web description: Web platform implementation of just_audio. This implementation is endorsed and therefore doesn't require a direct dependency. homepage: https://github.com/ryanheise/just_audio/tree/master/just_audio_web -version: 0.4.8 +version: 0.4.9 flutter: plugin: