Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement core::error::Error for error types #213

Open
PhilippGackstatter opened this issue Feb 25, 2025 · 3 comments
Open

Implement core::error::Error for error types #213

PhilippGackstatter opened this issue Feb 25, 2025 · 3 comments

Comments

@PhilippGackstatter
Copy link

Would you accept a PR or consider implementing core::error::Error for error types like EncodeError and DecodeError, now that the Error trait is available in core? This would allow no_std crates to wrap the error types as source errors into a Box<dyn Error> for example.

Thank you!

@apoelstra
Copy link
Member

The MSRV of this project is 1.63.0 so unfortunately we can't do this here.

@PhilippGackstatter
Copy link
Author

I see, thanks for the quick answer. I guess changing the MSRV depends on other dependent projects also increasing theirs which makes this tricky?

@apoelstra
Copy link
Member

Yes. Changing the MSRV would force downstream users to replace their compiler toolchain to one that isn't available in Debian, is a huge pain to build independently, which has potentially different behavior, and hasn't even existed for that long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants