Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trials of Mana official translation support #11

Open
rrooij opened this issue Aug 22, 2022 · 2 comments
Open

Add Trials of Mana official translation support #11

rrooij opened this issue Aug 22, 2022 · 2 comments

Comments

@rrooij
Copy link
Owner

rrooij commented Aug 22, 2022

So far we have support for most of the translations, but I think we have the Trials of Mana official translation missing that became a bit more common nowadays. No idea if the official translation uses a different encoding or save format than the Neill Corlett, SoM2Freak translation.

@richirisu
Copy link
Contributor

I've looked into the encoding scheme of the official international release from 2019, and the good news is that all languages have the same encoding. English, French, German, Spanish. Italian is not supported. In comparison to the translation patches, the new translation is a single byte encoding and it is very close to Latin-1. The most significant change is that it allows up to 12 characters for a name :)

The Japanese re-release is pretty much the same ROM as the one from 1995 and as such uses the same encoding as before.

I was able to implement the new encoding already. However, I came along a little shortage of the new encoding, and that is that it has multiple codepoints for the single and double quotation marks. So far, i have provided two translation options in the translation dropdown, one with and one without the fix. I went into more detail in the new documents I had committed alongside. I also made a PDF to visualize the codepoint mappings. I might remove that PDF again in the future...

Maybe you can look into my branch and tell me your opinion? I can also make adjustments before making a pull request.

@richirisu
Copy link
Contributor

One thing I have thought about is having the new names for characters, items, locations etc., if the new translation(s) is/are being used.

I see three possible ways to deal with it:

  1. Swap item/location entries entirely, e.g."Old Name" <-> "New Name"
  2. Have both item/location entries next to eachother, e.g. "Old Name / New Name"
    (The problem I see here is that different things might have the same name in each version. Not sure if that actuallly is the case though.)
  3. Keep it as is and only support the old names.

Eventually, also add support for the other languages (FRE, GER, ITA, JAP, SPA); thinking of the UI language and the language specific lists mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants