Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port #127 to ROS2 (Add support for VINT networkhub) #135

Closed
mintar opened this issue Apr 9, 2022 · 5 comments
Closed

Port #127 to ROS2 (Add support for VINT networkhub) #135

mintar opened this issue Apr 9, 2022 · 5 comments
Labels
enhancement help wanted

Comments

@mintar
Copy link
Contributor

mintar commented Apr 9, 2022 •
edited
Loading

See #127
@patilunmesh
Copy link

patilunmesh commented Feb 9, 2024 •
edited
Loading

Any update on this!? Is there a way to use ROS 2 with VINT hub? @mintar

mintar added a commit to mintar/phidgets_drivers that referenced this issue Feb 16, 2024
@mintar
Add support for VINT networkhub
fa3a5ec 
This is a port of ros-drivers#127 to ROS2.

Closes ros-drivers#135.
@mintar mintar mentioned this issue Feb 16, 2024
Merged
@mintar
Copy link
Contributor Author

mintar commented Feb 16, 2024

I've written a PR that should fix this: #172.

@patilunmesh, could you please test whether the PR works with the VINT hub and report back? Then I can merge it.

@patilunmesh
Copy link

@mintar, I can test this but at the first look it seems like it needs some changes in phidgets22.cpp, openWaitForAttachment function. I will get back once I test this.

@mintar
Copy link
Contributor Author

mintar commented Feb 18, 2024

It works on Noetic like this (with the temperature phidget), so I'm pretty confident it should work on ROS2 as well. I'm looking forward to hearing your results!

mintar added a commit that referenced this issue Mar 11, 2024
@mintar
Add support for VINT networkhub (#172)
6a6b81e 
This is a port of #127 to ROS2.

Closes #135.
@mintar
Copy link
Contributor Author

mintar commented Mar 11, 2024

Fixed via #172.

@mintar mintar closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mintar @patilunmesh