Fix #190 (#191)

Author: chainsawriot

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: readODS
 Type: Package
 Title: Read and Write ODS Files
-Version: 2.3.0
+Version: 2.3.1
 Authors@R: 
     c(person("Gerrit-Jan", "Schutten", role = c("aut"), email = "phonixor@gmail.com"),
     person("Chung-hong", "Chan", role = c("aut", "cre"), email = "chainsawtiney@gmail.com", comment = c(ORCID = "0000-0002-6232-7530")),

NEWS.md

@@ -1,3 +1,9 @@
+# readODS 2.3.1
+
+## Bug fixes
+
+* Fix #190 a potential GC issue in the vendored cpp11 code, detected by rchk 
+
 # readODS 2.3.0
 
 * Use `minty` instead of `readr` to reduce the number of dependencies

inst/include/cpp11/r_vector.hpp

@@ -918,12 +918,23 @@ inline r_vector<T>::operator SEXP() const {
   }
   if (length_ < capacity_) {
     p->data_ = truncate(p->data_, length_, capacity_);
+#if R_VERSION >= R_Version(3, 4, 0) && R_VERSION < R_Version(4, 5, 0)
     SEXP nms = names();
     auto nms_size = Rf_xlength(nms);
     if ((nms_size > 0) && (length_ < nms_size)) {
       nms = truncate(nms, length_, capacity_);
       names() = nms;
     }
+#else
+    SEXP nms;
+    PROTECT(nms = names());
+    auto nms_size = Rf_xlength(nms);
+    if ((nms_size > 0) && (length_ < nms_size)) {
+      nms = truncate(nms, length_, capacity_);
+      names() = nms;
+    }
+    UNPROTECT(1);
+#endif
   }
   return data_;
 }