Skip to content

Commit 4fdeb05

Browse files
authored
Fix #194 (#197)
1 parent 9652881 commit 4fdeb05

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/testthat/test_na.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ test_that("type_convert honoring na #2, issue 78", {
3232
expect_false(any(is.na(na_res$ex1[2:9])))
3333
expect_false(any(is.na(na_res$ex2[1:9])))
3434
expect_true(any(is.na(na_res$ex3[1:9]))) ## due to col_types
35-
expect_false(any(is.na(na_res$ex4[1:9])))
35+
## expect_false(any(is.na(na_res$ex4[1:9]))) ## buggy parsing behavior of readr::type_convert(); fixed in minty
3636
na_res <- read_ods('../testdata/na_test3.ods', na = c("one"), col_types = readr::cols(ex1 = "c", ex2 = "c", ex3 = "c", ex4 = "c"))
3737
expect_true(is.na(na_res[1,1]))
3838
expect_false(is.na(na_res[2,1]))
3939
expect_false(any(is.na(na_res$ex1[2:9])))
4040
expect_false(any(is.na(na_res$ex2[1:9])))
4141
expect_false(any(is.na(na_res$ex3[1:9])))
4242
expect_false(any(is.na(na_res$ex4[1:9])))
43-
})
43+
})

0 commit comments

Comments
 (0)