Merge pull request #96 from ropensci-review-tools/dev-resp

fix return value of model for dev responsiveness #87

Author: mpadge

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: repometrics
 Title: Metrics for Your Code Repository
-Version: 0.1.5.026
+Version: 0.1.5.028
 Authors@R: 
     person("Mark", "Padgham", , "mark.padgham@email.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265"))

R/cm-models.R

@@ -13,8 +13,9 @@
 #' measured in both mean and median forms, and converts all measured values to
 #' aggregate mean and median values.
 #'
-#' @return A numeric vector of two values for mean and median of overall
-#' response durations.
+#' @return A single numeric value of the mean of all of the four values. As
+#' this is in days, it is converted to log 10, with both NA values and values <
+#' 1 converted to values of 1 prior to log.
 #'
 #' @noRd
 cm_model_dev_responsiveness <- function (path,
@@ -53,8 +54,10 @@ cm_model_dev_responsiveness <- function (path,
     names (vals) <- c ("mean", "median")
     vals [which (is.na (vals))] <- NA_real_
 
-    # But only return mean value, to align with all others:
-    return (vals [["mean"]])
+    # But only return mean value, to align with all others
+    val <- vals [["mean"]]
+    val <- ifelse (is.na (val) | val < 1, 1, val)
+    return (log10 (val))
 }
 
 #' CHAOSS model "project engagement"

R/data-gh-workflow.R

@@ -100,5 +100,7 @@ coverage_from_one_log <- function (log_url) {
         fs::dir_delete (dirs_new)
     }
 
-    return (max (cov))
+    cov <- ifelse (length (cov) == 0L, NA_real_, max (cov))
+
+    return (cov)
 }

codemeta.json

@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/repometrics",
   "issueTracker": "https://github.com/ropensci-review-tools/repometrics/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.1.5.026",
+  "version": "0.1.5.028",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",