add test for change-requests metric #11

Author: mpadge

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: repometrics
 Title: Metrics for Your Code Repository
-Version: 0.1.1.007
+Version: 0.1.1.008
 Authors@R: 
     person("Mark", "Padgham", , "mark.padgham@email.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265"))

R/chaoss-metrics-internal-change-req.R

@@ -8,9 +8,16 @@
 #' 'Merge Requests' and Gerrit 'code reviews'." These are here analysed as
 #' merge commits in the git log, even though these may not have been actual PRs
 #' on GitHub or similar, and may not have been reviewed.
+#'
+#' @return NA if no commits made in given period, otherwise the proportion of
+#' commits which came from merged branches.
 #' noRd
 chaoss_internal_change_req <- function (path, end_date = Sys.Date ()) {
 
     log <- git_log_in_period (path, end_date, get_repometrics_period ())
-    length (which (log$merge)) / nrow (log)
+    res <- NA_integer_
+    if (nrow (log) > 0L) {
+        res <- length (which (log$merge)) / nrow (log)
+    }
+    return (res)
 }

codemeta.json

@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/repometrics",
   "issueTracker": "https://github.com/ropensci-review-tools/repometrics/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.1.1.007",
+  "version": "0.1.1.008",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",

tests/testthat/test-chaoss-metrics-internal.R

@@ -1,12 +1,14 @@
+end_date <- as.Date ("2024-08-01")
+
 test_that ("chaoss internal num_commits", {
     pkg <- system.file ("extdata", "testpkg.zip", package = "repometrics")
     flist <- unzip (pkg, exdir = fs::path_temp ())
     path <- fs::path_dir (flist [1])
 
-    n <- chaoss_internal_num_commits (path, end_date = as.Date ("2024-08-01"))
+    n <- chaoss_internal_num_commits (path, end_date = end_date)
     expect_equal (n, 4L)
 
-    n <- chaoss_internal_num_contributors (path, end_date = as.Date ("2024-08-01"))
+    n <- chaoss_internal_num_contributors (path, end_date = end_date)
     expect_equal (n, 1L)
 
     fs::dir_delete (path)
@@ -38,3 +40,16 @@ test_that ("chaoss has CI internal", {
 
     fs::dir_delete (path)
 })
+
+test_that ("chaoss internal change requests", {
+    pkg <- system.file ("extdata", "testpkg.zip", package = "repometrics")
+    flist <- unzip (pkg, exdir = fs::path_temp ())
+    path <- fs::path_dir (flist [1])
+
+    x <- chaoss_internal_change_req (path, end_date = end_date)
+    expect_equal (x, 0)
+    x <- chaoss_internal_change_req (path, end_date = Sys.Date ())
+    expect_equal (x, NA_integer_) # no commits, so NA returned
+
+    fs::dir_delete (path)
+})