Merge pull request #36 from ropensci-review-tools/issues-to-prs

issues to prs for #11

Author: mpadge

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: repometrics
 Title: Metrics for Your Code Repository
-Version: 0.1.1.104
+Version: 0.1.1.108
 Authors@R: 
     person("Mark", "Padgham", , "mark.padgham@email.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265"))

R/cm-metric-issues-to-prs.R

@@ -0,0 +1,23 @@
+cm_metric_issues_to_prs <- function (path, end_date = Sys.Date ()) {
+
+    prs <- get_prs_in_period (path, end_date) # in cm-metrics-change-req.R
+    issues <- get_issues_in_period (path, end_date)
+
+    ret <- 1
+    if (nrow (prs) > 0) {
+        ret <- nrow (issues) / nrow (prs)
+    }
+
+    return (ret)
+}
+
+get_issues_in_period <- function (path, end_date = Sys.Date ()) {
+
+    issues <- cm_data_issues_from_gh_api (path)
+    created_dates <- as.Date (issues$created_at)
+    closed_dates <- as.Date (issues$closed_at)
+    start_date <- end_date - get_repometrics_period ()
+    index <- which (created_dates >= start_date & closed_dates <= end_date)
+
+    return (issues [index, ])
+}

R/cm-metrics-change-req.R

@@ -20,14 +20,21 @@ cm_metric_change_req <- function (path, end_date = Sys.Date ()) {
         return (0)
     }
 
+    prs <- get_prs_in_period (path, end_date)
+
+    res <- sum (prs$num_commits) / nrow (log)
+
+    return (res)
+}
+
+get_prs_in_period <- function (path, end_date = Sys.Date ()) {
+
     prs <- cm_data_prs_from_gh_api (path)
     prs <- prs [which (prs$merged), ]
     closed_dates <- as.Date (prs$closed_at)
     start_date <- end_date - get_repometrics_period ()
     index <- which (closed_dates >= start_date & closed_dates <= end_date)
     prs <- prs [index, ]
 
-    res <- sum (prs$num_commits) / nrow (log)
-
-    return (res)
+    return (prs)
 }

codemeta.json

@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/repometrics",
   "issueTracker": "https://github.com/ropensci-review-tools/repometrics/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.1.1.104",
+  "version": "0.1.1.108",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",

tests/testthat/test-cm-metrics.R

@@ -95,3 +95,16 @@ test_that ("cm metrics change req frequency", {
     expect_length (dat, 1L)
     expect_equal (dat, 0.)
 })
+
+test_that ("cm metrics issues-to-prs", {
+
+    Sys.setenv ("REPOMETRICS_TESTS" = "true")
+    mock_cm_data ()
+    path <- generate_test_pkg ()
+    x <- cm_metric_issues_to_prs (path, end_date = end_date)
+    fs::dir_delete (path)
+
+    expect_type (x, "double")
+    expect_length (x, 1L)
+    expect_true (x > 0)
+})