Merge pull request #41 from ropensci-review-tools/approvals

review cycle metrics for #4

Author: mpadge

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: repometrics
 Title: Metrics for Your Code Repository
-Version: 0.1.1.117
+Version: 0.1.1.120
 Authors@R: 
     person("Mark", "Padgham", , "mark.padgham@email.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265"))

R/cm-data-gh-prs.R

@@ -43,6 +43,7 @@ gh_prs_qry <- function (org = "ropensci-review-tools",
                             author {
                                 login
                             }
+                            createdAt
                             submittedAt
                             state
                             body
@@ -182,16 +183,37 @@ cm_data_prs_from_gh_api_internal <- function (path, n_per_page = 30L) {
             character (1L)
         )
         state <- vapply (i$reviews$nodes, function (j) j$state, character (1L))
+        created_at <- vapply (
+            i$reviews$nodes,
+            function (j) null2na_char (j$createdAt),
+            character (1L)
+        )
         submitted_at <- vapply (
             i$reviews$nodes,
             function (j) null2na_char (j$submittedAt),
             character (1L)
         )
         body <- vapply (i$reviews$nodes, function (j) j$body, character (1L))
+
+        num_comments <- i$totalCommentsCount
+
+        lens <- c (length (login), length (state), length (created_at), length (submitted_at))
+        has_content <- any (lens > 0L) | num_comments > 0L
+
+        if (has_content) {
+            login <- null2na_char (login)
+            state <- null2na_char (state)
+            submitted_at <- null2na_char (submitted_at)
+            body <- null2na_char (body)
+        } else {
+            num_comments <- integer (0L)
+        }
+
         data.frame (
             login = login,
             state = state,
             submitted_at = submitted_at,
+            num_comments = num_comments,
             body = body
         )
     })

R/cm-metric-pr-reviews.R

@@ -40,7 +40,7 @@ cm_metric_pr_reviews <- function (path, end_date = Sys.Date ()) {
     }
 
     mean_to_na <- function (x) {
-        ifelse (length (x) == 0L, NA, mean (x))
+        ifelse (length (x) == 0L, NA_real_, mean (x))
     }
 
     pr_duration <- difftime (prs$closed_at, prs$created_at, units = "days")
@@ -88,3 +88,38 @@ cm_metric_pr_reviews <- function (path, end_date = Sys.Date ()) {
 
     return (ret)
 }
+
+cm_metric_pr_review_duration <- function (path, end_date = Sys.Date ()) {
+
+    prs <- get_prs_in_period (path, end_date) # in cm-metrics-change-req.R
+
+    prs$created_at <- as.Date (prs$created_at)
+    prs$closed_at <- as.Date (prs$closed_at)
+
+    index_approved <- which (prs$review_decision == "APPROVED")
+
+    cycle_dur <- vapply (prs$reviews, function (i) {
+        dates <- as.Date (i$submitted_at)
+        ret <- NA_real_
+        if (length (dates) > 1L) {
+            dt <- diff (dates, units = "days")
+            ret <- mean (as.integer (dt))
+        }
+        return (ret)
+    }, numeric (1L))
+    cycle_dur <- as.numeric (cycle_dur)
+    cycle_dur_mn <- mean (cycle_dur [index_approved], na.rm = TRUE)
+    cycle_dur_md <- stats::median (cycle_dur [index_approved], na.rm = TRUE)
+
+    review_dur <- difftime (prs$closed_at, prs$created_at, units = "days")
+    review_dur <- as.numeric (review_dur)
+    review_dur_mn <- mean (review_dur [index_approved], na.rm = TRUE)
+    review_dur_md <- stats::median (review_dur [index_approved], na.rm = TRUE)
+
+    c (
+        cycle_dur_mn = cycle_dur_mn,
+        cycle_dur_md = cycle_dur_md,
+        review_dur_mn = review_dur_mn,
+        review_dur_md = review_dur_md
+    )
+}

codemeta.json

@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/repometrics",
   "issueTracker": "https://github.com/ropensci-review-tools/repometrics/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.1.1.117",
+  "version": "0.1.1.120",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",

tests/testthat/gh_api_ctbs/ghusers/gaborcsardi.json

@@ -28,7 +28,7 @@
     "twitter_username": null,
     "public_repos": 194,
     "public_gists": 19,
-    "followers": 1432,
+    "followers": 1431,
     "following": 0,
     "created_at": "2011-03-09T17:29:25Z",
     "updated_at": "2024-11-18T09:12:36Z"

tests/testthat/gh_api_prs/api.github.com/graphql-5ab71e-POST.json tests/testthat/gh_api_prs/api.github.com/graphql-d5112a-POST.json

@@ -112,6 +112,7 @@
                                     "author": {
                                         "login": "gaborcsardi"
                                     },
+                                    "createdAt": "2016-12-01T10:36:38Z",
                                     "submittedAt": "2016-12-01T10:41:46Z",
                                     "state": "COMMENTED",
                                     "body": ""
@@ -120,6 +121,7 @@
                                     "author": {
                                         "login": "LiNk-NY"
                                     },
+                                    "createdAt": "2016-12-23T18:51:38Z",
                                     "submittedAt": "2016-12-23T18:51:38Z",
                                     "state": "COMMENTED",
                                     "body": ""
@@ -128,6 +130,7 @@
                                     "author": {
                                         "login": "LiNk-NY"
                                     },
+                                    "createdAt": "2016-12-23T18:52:02Z",
                                     "submittedAt": "2016-12-23T18:52:02Z",
                                     "state": "COMMENTED",
                                     "body": ""
@@ -136,6 +139,7 @@
                                     "author": {
                                         "login": "LiNk-NY"
                                     },
+                                    "createdAt": "2016-12-23T18:55:59Z",
                                     "submittedAt": "2016-12-23T18:55:59Z",
                                     "state": "COMMENTED",
                                     "body": ""

tests/testthat/test-cm-metrics.R

@@ -164,3 +164,18 @@ test_that ("cm metrics code change lines", {
     }
     expect_true (x2 > x1)
 })
+
+test_that ("cm metrics review duration", {
+
+    Sys.setenv ("REPOMETRICS_TESTS" = "true")
+    mock_cm_data ()
+    path <- generate_test_pkg ()
+    revs <- cm_metric_pr_review_duration (path, end_date = end_date)
+    fs::dir_delete (path)
+
+    expect_type (revs, "double")
+    expect_length (revs, 4L)
+    expect_named (revs)
+    nms <- c ("cycle_dur_mn", "cycle_dur_md", "review_dur_mn", "review_dur_md")
+    expect_equal (names (revs), nms)
+})