Merge pull request #118 from ropensci-review-tools/gh-user

fix data-gh-user when user has made no comments

Author: mpadge

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: repometrics
 Title: Metrics for Your Code Repository
-Version: 0.1.6.063
+Version: 0.1.6.064
 Authors@R: 
     person("Mark", "Padgham", , "mark.padgham@email.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265"))

R/data-gh-user.R

@@ -686,47 +686,50 @@ gh_user_issue_cmts_internal <- function (login,
         issue_comment_counts <-
             issue_comment_counts + dat$data$user$issueComments$totalCount
 
-        nodes <- dat$data$user$issueComments$nodes
+        if (issue_comment_counts > 0L) {
 
-        created_at <- c (
-            created_at,
-            vapply (nodes, function (i) i$createdAt, character (1L))
-        )
-        org_repo <- c (
-            org_repo,
-            vapply (
-                nodes,
-                function (i) i$issue$repository$nameWithOwner,
-                character (1L)
+            nodes <- dat$data$user$issueComments$nodes
+
+            created_at <- c (
+                created_at,
+                vapply (nodes, function (i) i$createdAt, character (1L))
             )
-        )
-        issue_num <- c (
-            issue_num,
-            vapply (
-                nodes, function (i) i$issue$number,
-                integer (1L)
+            org_repo <- c (
+                org_repo,
+                vapply (
+                    nodes,
+                    function (i) i$issue$repository$nameWithOwner,
+                    character (1L)
+                )
             )
-        )
-        num_comments <- c (
-            num_comments,
-            vapply (
-                nodes,
-                function (i) i$issue$comments$totalCount,
-                integer (1L)
+            issue_num <- c (
+                issue_num,
+                vapply (
+                    nodes, function (i) i$issue$number,
+                    integer (1L)
+                )
             )
-        )
-        num_participants <- c (
-            num_participants,
-            vapply (
-                nodes,
-                function (i) i$issue$participants$totalCount,
-                integer (1L)
+            num_comments <- c (
+                num_comments,
+                vapply (
+                    nodes,
+                    function (i) i$issue$comments$totalCount,
+                    integer (1L)
+                )
+            )
+            num_participants <- c (
+                num_participants,
+                vapply (
+                    nodes,
+                    function (i) i$issue$participants$totalCount,
+                    integer (1L)
+                )
             )
-        )
 
-        if (utils::tail (as.POSIXct (created_at), 1) < start_timestamp) {
-            has_next_page <- FALSE
-        }
+            if (utils::tail (as.POSIXct (created_at), 1) < start_timestamp) {
+                has_next_page <- FALSE
+            }
+        } # else will always have has_next_page = FALSE
     }
 
     data.frame (

codemeta.json

@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/repometrics",
   "issueTracker": "https://github.com/ropensci-review-tools/repometrics/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.1.6.063",
+  "version": "0.1.6.064",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",