Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading magnitude format in test csvs #947

Open
pebasantaf opened this issue Jun 29, 2022 · 1 comment
Open

Misleading magnitude format in test csvs #947

pebasantaf opened this issue Jun 29, 2022 · 1 comment

Comments

@pebasantaf
Copy link
Collaborator

Often the unit for an energy price or cost has a magnitude format such as 'currency/kWh' or 'currency/kW' in the csvs. This works if we use kWh or kW correspondingly as units. But it is misleading in case we use, for example, kgH2 as unit. People might have a a tendency to pass those kgH2 to kWh as, for example, in the energy_price of EnergyProviders is indicated to input this value with a 'currency/kWh' format, but the optimizer is actually working with kgH2, if one has set it as unit. Therefore, the magnitude format for this energy_price (and other variables) should be 'currency/unit'.

@Bachibouzouk
Copy link
Collaborator

Bachibouzouk commented Aug 5, 2022

As far as I know, the unit in the csv file is up to the user to define, I should have time to test that soon as we need to make sure the use of unit is consistent for another project where we use MVS (This is essentially a GUI of MVS: https://github.com/open-plan-tool).

There is a dict with energy conversion factors :

DEFAULT_WEIGHTS_ENERGY_CARRIERS = {

I will also empower the user to change those factors more easily in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants