Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iFrame Support #5

Open
MentalGear opened this issue Jun 26, 2016 · 3 comments
Open

iFrame Support #5

MentalGear opened this issue Jun 26, 2016 · 3 comments

Comments

@MentalGear
Copy link

Is there a way we could build in support for iFrames, e.g. twiier widget atm are still white.

@rileyjshaw
Copy link
Owner

Hi @MentalGear!

This might be fixed in the version I just published a new version (v4.0.8). Can you confirm if it's fixed in the new version?

(It usually takes a few hours for the update to reach your browser)

@MentalGear
Copy link
Author

MentalGear commented Jun 27, 2016

Hi Riley,
Unfortunately, iFrame elements like embedded tweets are still white. CSS Injection doesn't penetrate through the iFrame.
Reasons for this could be:

  • a. twitter's iFrames uses shadow dom
  • b. because it's a dynamic iFrame (loaded after page load) and the extension needs to wait for iFrame to be ready (waitUntilExists) and inject CSS then into the iFrame ?

@rileyjshaw
Copy link
Owner

rileyjshaw commented Jun 28, 2016

I'm not going to have time to look into this for a while, but a good starting point would be to remove the "Skip iframes" logic from client.js. The tab id and url logic in background.js for com.rileyjshaw.dte__READY will then need some work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants