fix: making sure 'for' attribute is always defined for alerts as this is required by RHOBS

Author: Nikokolas3270

main.go

@@ -43,9 +43,15 @@ type genericObj struct {
 	Spec       yaml.Node
 }
 
+type ruleObj struct {
+	For   string `yaml:",omitempty"`
+	Alert string
+}
+
 type ruleGroupObj struct {
 	Name     string
 	Interval string `yaml:",omitempty"`
+	Rules    []ruleObj
 }
 
 type ruleGroupsObj struct {
@@ -330,6 +336,12 @@ func checkRules(rulesDirPath, tenant string, isGeneratingTemplate bool) {
 					if ruleGroupObj.Interval == "" {
 						return fmt.Errorf("attribute 'spec.groups[].interval' is missing for some group named '%s'", ruleGroupObj.Name)
 					}
+
+					for _, ruleObj := range ruleGroupObj.Rules {
+						if ruleObj.Alert != "" && ruleObj.For == "" {
+							return fmt.Errorf("attribute 'spec.groups[].rules[].for' is missing for some alert named '%s' in group '%s'", ruleObj.Alert, ruleGroupObj.Name)
+						}
+					}
 				}
 			}