Skip to content

Commit cbabe00

Browse files
committed
Add contribution guide, changelog, release.nix
1 parent 7faa08b commit cbabe00

File tree

6 files changed

+93
-0
lines changed

6 files changed

+93
-0
lines changed

CONTRIBUTING.md

+68
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
# Contribution Guide
2+
3+
Contributions and issue reports are encouraged and appreciated!
4+
5+
- [Opening Issues](#opening-issues)
6+
- [Submitting Changes](#submitting-changes)
7+
- [Guidelines for Commit Messages](#guidelines-for-commit-messages)
8+
- [Guidelines for Pull Requests](#guidelines-for-pull-requests)
9+
- [Code Quality](#code-quality)
10+
- [Documentation](#documentation)
11+
12+
## Opening Issues
13+
14+
Before opening an issue, please check whether your issue has already been reported. Assuming it has not:
15+
16+
* Describe the issue you're encountering or the suggestion you're making
17+
* Include any relevant steps to reproduce or code samples you can. It's always easier for us to debug if we have something that demonstrates the error.
18+
* Let us know what version of reflex-vty you were using. If you're using a github checkout, provide the git hash.
19+
* Describe how you're building reflex-vty (i.e., via reflex-platform, cabal install, stack, obelisk, etc.).
20+
21+
## Submitting Changes
22+
23+
### Guidelines for Commit Messages
24+
25+
#### Summary Line
26+
The summary line of your commit message should summarize the changes being made. Commit messages should be written in the imperative mood and should describe what happens when the commit is applied.
27+
28+
One way to think about it is that your commit message should be able to complete the sentence:
29+
"When applied, this commit will..."
30+
31+
#### Body
32+
For breaking changes, new features, refactors, or other major changes, the body of the commit message should describe the motivation behind the change in greater detail and may include references to the issue tracker. The body shouldn't repeat code/comments from the diff.
33+
34+
### Guidelines for Pull Requests
35+
36+
Wherever possible, pull requests should add a single feature or fix a single bug. Pull requests should not bundle several unrelated changes.
37+
38+
### Code Quality
39+
40+
#### Warnings
41+
42+
Your pull request should add no new warnings to the project. It should also generally not disable any warnings.
43+
44+
#### Build and Test
45+
46+
Make sure the project builds and that the tests pass! This will generally also be checked by CI before merge, but trying it yourself first means you'll catch problems earlier and your contribution can be merged that much sooner!
47+
48+
To check that things are still working, run:
49+
50+
```bash
51+
nix-build release.nix
52+
```
53+
54+
### Documentation
55+
56+
#### In the code
57+
We're always striving to improve documentation. Please include [haddock](https://haskell-haddock.readthedocs.io/en/latest/index.html) documentation for any added code, and update the documentation for any code you modify.
58+
59+
#### In the [Changelog](ChangeLog.md)
60+
Add an entry to the changelog when your PR:
61+
* Adds a feature
62+
* Deprecates something
63+
* Includes a breaking change
64+
* Makes any other change that will impact users
65+
66+
#### In the [Readme](README.md)
67+
The readme is the first place a lot of people look for information about the repository. Update any parts of the readme that are affected by your PR.
68+

ChangeLog.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Revision history for reflex-vty
2+
3+
## 0.1.0.0
4+
5+
* Initial release

reflex-platform/default.nix

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# DO NOT HAND-EDIT THIS FILE
2+
import ((import <nixpkgs> {}).fetchFromGitHub (
3+
let json = builtins.fromJSON (builtins.readFile ./github.json);
4+
in { inherit (json) owner repo rev sha256;
5+
private = json.private or false;
6+
}
7+
))

reflex-platform/github.json

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"owner": "reflex-frp",
3+
"repo": "reflex-platform",
4+
"branch": "develop",
5+
"rev": "51e02339704b7502e63bccf10a72fa4dda744b17",
6+
"sha256": "1mkimidf755968xzbm3z222xgpdvgg6xmmrfppv1hw0rap5w53iw"
7+
}

reflex-vty.cabal

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ maintainer: maintainer@obsidian.systems
1212
category: FRP
1313
build-type: Simple
1414
cabal-version: >=1.10
15+
extra-source-files: README.md
16+
ChangeLog.md
1517
extra-doc-files: doc/welcome.gif
1618
, doc/tasks.png
1719

release.nix

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{ rp ? import ./reflex-platform {}
2+
}: {
3+
reflex-vty = rp.ghc.callCabal2nix ./. {};
4+
}

0 commit comments

Comments
 (0)