Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hijackable Logger #91

Open
crazytyper opened this issue Aug 27, 2015 · 0 comments
Open

Hijackable Logger #91

crazytyper opened this issue Aug 27, 2015 · 0 comments

Comments

@crazytyper
Copy link

Given a tigertonic based server that serves both REST and web socket endpoints.
And the server uses a logged HTTP handler (e.g. tigertonic.ApacheLogged()).

When accessing a web socket API the request will fail complaining that apacheLoggerResponseWriter is not hijack-able (i.e. does not implement http.Hijacker).

The logged HTTP handlers should use response writers that are fully transparent. The logged response writer should support hijacking if the underlying response writer does.

A simple fix would be to add method Hijack to the logged response writers. However, this does not feel 100% right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant