Skip to content

Commit ab60081

Browse files
excluding remote models from max node per node setting (opensearch-project#2732) (opensearch-project#2738)
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 9ea79d0) Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
1 parent ce6b36c commit ab60081

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

plugin/src/main/java/org/opensearch/ml/model/MLModelManager.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,7 @@ public void deployModel(
990990
mlStats.createModelCounterStatIfAbsent(modelId, ActionName.DEPLOY, ML_ACTION_REQUEST_COUNT).increment();
991991
List<String> workerNodes = mlTask.getWorkerNodes();
992992
if (modelCacheHelper.isModelDeployed(modelId)) {
993-
if (!autoDeployModel && workerNodes != null && workerNodes.size() > 0) {
993+
if (!autoDeployModel && workerNodes != null && !workerNodes.isEmpty()) {
994994
log.info("Set new target node ids {} for model {}", Arrays.toString(workerNodes.toArray(new String[0])), modelId);
995995
modelCacheHelper.setDeployToAllNodes(modelId, deployToAllNodes);
996996
modelCacheHelper.setTargetWorkerNodes(modelId, workerNodes);
@@ -999,7 +999,7 @@ public void deployModel(
999999
listener.onResponse("successful");
10001000
return;
10011001
}
1002-
if (modelCacheHelper.getLocalDeployedModels().length >= maxModelPerNode) {
1002+
if (functionName != FunctionName.REMOTE && modelCacheHelper.getLocalDeployedModels().length >= maxModelPerNode) {
10031003
listener.onFailure(new IllegalArgumentException("Exceed max local model per node limit"));
10041004
return;
10051005
}

0 commit comments

Comments
 (0)