RD 10961 + RD 10948 fixes #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexzerntev
commented
May 29, 2024
alexzerntev
commented
- Added support for multiline strings and quoted identifiers
- Fixed the position out of grid crash
bgaidioz
reviewed
May 30, 2024
sql-client/src/test/scala/raw/client/sql/TestSqlCompilerServiceAirports.scala
Show resolved
Hide resolved
sql-client/src/test/scala/raw/client/sql/TestSqlCompilerServiceAirports.scala
Show resolved
Hide resolved
| val ValidateResponse(errors) = compilerService.validate(q, asJson()) | ||
| assert(errors.nonEmpty) | ||
| } | ||
|
|
||
| test("""RD-10948"""){_ => | ||
| test("""RD-10948""") { _ => |
There was a problem hiding this comment.
Let's not forget to remove that test.
There was a problem hiding this comment.
I alternated it as we discussed
| | (2, 'Jane', 'Doe', DATE '2024-01-01') | ||
| |) as i(id, first_name, last_name, birthday) | ||
| |WHERE id = :id && id = : | ||
| |""".stripMargin | ||
| val ValidateResponse(errors) = compilerService.validate(q, asJson()) | ||
| assert(errors.nonEmpty) |
There was a problem hiding this comment.
The test would crash during the line before. What error does one get now?
There was a problem hiding this comment.
syntax error at or near "="
Is this error expected?
|
This test: test("Test multiple param occurrences")fails. This is new. I see the test code contains an extra |
bgaidioz
approved these changes
May 30, 2024
bgaidioz
pushed a commit
that referenced
this pull request
May 30, 2024
- Added support for multiline strings and quoted identifiers - Fixed the position out of grid crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.