(Truffle optimizations) Final truffle optimizations #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexzerntev
commented
Mar 10, 2024
•
alexzerntev
commented
- Separated pure records from records with duplicate keys
- Made more PE friendly nullables and tryables
- Fixed record operations to have a specialization instance per field per operation (as truffle docs suggest)
- Added toString() overrides for better debugging
- Merged TreeMap implementation to get and put with one walk
- Added missing TruffleBoundaries
- Removed language and context storage from runtime objects. It can be accessed from inside the nodes (also made it cached)
alexzerntev
force-pushed
the
experimenting-with-record-concatanation
branch
from
6ba4685 to
bd29f6c
Compare
alexzerntev
commented
Mar 19, 2024
| updateDistinctKeys(); | ||
| } | ||
|
|
||
| private void updateDistinctKeys() { |
There was a problem hiding this comment.
Add @TruffleBoundary
|
Merging into initial PR (#352) . The review will be done here. |
alexzerntev
changed the base branch from
main
to
RD-10562-implement-osr-for-iterators
alexzerntev
changed the base branch from
RD-10562-implement-osr-for-iterators
to
main
alexzerntev
changed the title
alexzerntev
commented
Mar 27, 2024
|
|
||
| // Static properties for dynamic object storage types | ||
| public class PropertyType { | ||
| public static final byte INT_TYPE = 0; |
There was a problem hiding this comment.
To check for short and byte
alexzerntev
commented
Mar 27, 2024
| return RawTypesGen.expectPureRecord(executeGeneric(virtualFrame)); | ||
| } | ||
|
|
||
| public DuplicateKeyRecord executeConcatRecord(VirtualFrame virtualFrame) |
This was referenced Mar 27, 2024
bgaidioz
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.