✨ Enable CAPI UI extension installation for development purposes #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
auto-install-ui
branch
3 times, most recently
from
28ead87 to
d463f94
Compare
anmazzotti
previously approved these changes
Feb 17, 2025
yiannistri
previously approved these changes
Feb 18, 2025
Danil-Grigorev
dismissed stale reviews from yiannistri and anmazzotti
via
eaf8ab2
anmazzotti
previously approved these changes
Feb 18, 2025
alexander-demicev
previously approved these changes
Feb 18, 2025
| // SetupWithManager sets up the controller with the Manager. | ||
| func (r *UIPluginReconciler) SetupWithManager(_ context.Context, mgr ctrl.Manager, _ controller.Options) error { | ||
| uiPlugin := &metav1.PartialObjectMetadata{} | ||
| uiPlugin.SetGroupVersionKind(schema.GroupVersionKind{ |
There was a problem hiding this comment.
should this be a part of the rancher API wrapper?
There was a problem hiding this comment.
It can be, but this controller does not set any spec fields, only moves the UI plugin to the cattle-ui-system-namespace, once this namespace is created. It may also be used later to not move and simply delete UIPlugin if it interferes with existing one in the namespace already. Helm has problems with cleaning up or replacing resources if they weren’t created by it, so a controller is better suited to accommodate this custom logic.
Danil-Grigorev
dismissed stale reviews from alexander-demicev and anmazzotti
via
253dea1
Danil-Grigorev
force-pushed
the
auto-install-ui
branch
2 times, most recently
from
253dea1 to
2963f1d
Compare
anmazzotti
previously approved these changes
Feb 20, 2025
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
auto-install-ui
branch
from
2963f1d to
8aa63dc
Compare
anmazzotti
approved these changes
Feb 20, 2025
|
I think we need to postpone this addition until we have a clear installation path supported by the org. I’ll close it for now. |
Danil-Grigorev
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #1082