Handle missing agent-tls-mode Setting value (#996)

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>

internal/controllers/helpers.go

@@ -315,7 +315,12 @@ func getTrustedCAcert(ctx context.Context, cl client.Client, agentTLSModeFeature
 		return nil, fmt.Errorf("error getting agent-tls-mode setting: %w", err)
 	}
 
-	switch agentTLSModeSetting.Value {
+	agentTLSModeValue := agentTLSModeSetting.Value
+	if len(agentTLSModeValue) == 0 {
+		agentTLSModeValue = agentTLSModeSetting.Default
+	}
+
+	switch agentTLSModeValue {
 	case "system-store":
 		log.Info("using system store for CA certificates")
 		return nil, nil
@@ -336,6 +341,6 @@ func getTrustedCAcert(ctx context.Context, cl client.Client, agentTLSModeFeature
 
 		return []byte(caCertsSetting.Value), nil
 	default:
-		return nil, fmt.Errorf("invalid agent-tls-mode setting value: %s", agentTLSModeSetting.Value)
+		return nil, fmt.Errorf("invalid agent-tls-mode setting value: %s", agentTLSModeValue)
 	}
 }

internal/controllers/helpers_test.go

@@ -79,6 +79,17 @@ var _ = Describe("getTrustedCAcert", func() {
 		Expect(result).To(Equal([]byte("cert-data")))
 	})
 
+	It("should use default agent-tls-mode when value is empty", func() {
+		agentTLSModeSetting.Value = ""
+		agentTLSModeSetting.Default = "strict"
+		Expect(fakeClient.Create(ctx, agentTLSModeSetting)).To(Succeed())
+		Expect(fakeClient.Create(ctx, cacertsSetting)).To(Succeed())
+
+		result, err := getTrustedCAcert(ctx, fakeClient, true)
+		Expect(err).NotTo(HaveOccurred())
+		Expect(result).To(Equal([]byte("cert-data")))
+	})
+
 	It("should return error when agent-tls-mode is strict and cacerts is empty", func() {
 		cacertsSetting.Value = ""
 		Expect(fakeClient.Create(ctx, agentTLSModeSetting)).To(Succeed())
@@ -99,4 +110,15 @@ var _ = Describe("getTrustedCAcert", func() {
 		Expect(err.Error()).To(ContainSubstring("invalid agent-tls-mode setting value"))
 		Expect(result).To(BeNil())
 	})
+
+	It("should return error for missing agent-tls-mode value and default", func() {
+		agentTLSModeSetting.Value = ""
+		agentTLSModeSetting.Default = ""
+		Expect(fakeClient.Create(ctx, agentTLSModeSetting)).To(Succeed())
+
+		result, err := getTrustedCAcert(ctx, fakeClient, true)
+		Expect(err).To(HaveOccurred(), "Should not make assumptions on default agent-tls-mode value")
+		Expect(err.Error()).To(ContainSubstring("invalid agent-tls-mode setting value"))
+		Expect(result).To(BeNil())
+	})
 })