From ad0255204653cfb69f39b45e9367135c301ce2ff Mon Sep 17 00:00:00 2001 From: Carlos Scheidegger Date: Fri, 16 Feb 2024 12:13:41 -0700 Subject: [PATCH] ff matrix: add 'comment' field, work on float/crossref/tables --- dev-docs/feature-format-matrix/.gitignore | 2 + dev-docs/feature-format-matrix/_quarto.yml | 2 + dev-docs/feature-format-matrix/_tabulator.qmd | 4 -- .../feature-format-matrix/create_table.py | 9 ++- dev-docs/feature-format-matrix/index.css | 11 +++ dev-docs/feature-format-matrix/index.qmd | 11 +++ .../feature-format-matrix/media/table.jpg | Bin 0 -> 19199 bytes .../qmd-files/callout/document.qmd | 43 ++--------- .../crossref/float/table/document.ipynb | 53 ++++++++++++++ .../crossref/float/table/document.qmd | 68 +++++++++++++++++- 10 files changed, 155 insertions(+), 48 deletions(-) create mode 100644 dev-docs/feature-format-matrix/_quarto.yml create mode 100644 dev-docs/feature-format-matrix/index.css create mode 100644 dev-docs/feature-format-matrix/media/table.jpg create mode 100644 dev-docs/feature-format-matrix/qmd-files/crossref/float/table/document.ipynb diff --git a/dev-docs/feature-format-matrix/.gitignore b/dev-docs/feature-format-matrix/.gitignore index 4db1c3a967..58d8cfd09b 100644 --- a/dev-docs/feature-format-matrix/.gitignore +++ b/dev-docs/feature-format-matrix/.gitignore @@ -5,3 +5,5 @@ qmd-files/**/*.html qmd-files/**/*.pdf qmd-files/**/*.md qmd-files/**/*.mdx + +/.quarto/ diff --git a/dev-docs/feature-format-matrix/_quarto.yml b/dev-docs/feature-format-matrix/_quarto.yml new file mode 100644 index 0000000000..d63aa6ddef --- /dev/null +++ b/dev-docs/feature-format-matrix/_quarto.yml @@ -0,0 +1,2 @@ +project: + title: "Feature format matrix" diff --git a/dev-docs/feature-format-matrix/_tabulator.qmd b/dev-docs/feature-format-matrix/_tabulator.qmd index c243ab2abd..a2d4550728 100644 --- a/dev-docs/feature-format-matrix/_tabulator.qmd +++ b/dev-docs/feature-format-matrix/_tabulator.qmd @@ -1,7 +1,3 @@ ---- -css: dist/css/tabulator.min.css ---- - ```{=html} ``` diff --git a/dev-docs/feature-format-matrix/create_table.py b/dev-docs/feature-format-matrix/create_table.py index 1a26e4ba06..9076c39955 100644 --- a/dev-docs/feature-format-matrix/create_table.py +++ b/dev-docs/feature-format-matrix/create_table.py @@ -88,12 +88,15 @@ def table_cell(entry, _feature, _format_name, format_config): result = [] quality = format_config.get("quality", "unknown") if quality is not None: - # use forbidden sign for -1, yellow circle for 0, and green circle for 1 qualities = {-1: "🚫", 0: "⚠", 1: "✓", 2: "✓✓"} - colors = {-1: "#b05050", 0: "#c09060", 1: "#50b050", 2: "#50b050", "unknown": "inherit", "na": "inherit"} + colors = {-1: "bad", 0: "ok", 1: "good", 2: "good", "unknown": "unknown", "na": "na"} color = colors[quality] quality_icon = qualities.get(quality, "❓") - result.append(f"{quality_icon}") + result.append(f"{quality_icon}") + comment = format_config.get("comment", None) + if comment is not None: + # This is going to be an accessibility problem + result.append(f"💬") return "".join(result) def compute_trie(): diff --git a/dev-docs/feature-format-matrix/index.css b/dev-docs/feature-format-matrix/index.css new file mode 100644 index 0000000000..d2ab4a284a --- /dev/null +++ b/dev-docs/feature-format-matrix/index.css @@ -0,0 +1,11 @@ +.bad { + color: #b05050; +} + +.ok { + color: #c09060; +} + +.good { + color: #60b050; +} diff --git a/dev-docs/feature-format-matrix/index.qmd b/dev-docs/feature-format-matrix/index.qmd index 6b9a9610ab..a7a4d076d1 100644 --- a/dev-docs/feature-format-matrix/index.qmd +++ b/dev-docs/feature-format-matrix/index.qmd @@ -2,6 +2,9 @@ engine: jupyter format: html title: Features x Formats +css: + - index.css + - dist/css/tabulator.min.css ---