Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tritonbench][gemm] Allow omitting the "Bias" column in data table #2412

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchbenchmark/operators/gemm/data_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def read_shapes_from_csv(csv_path: str) -> List[List[int]]:
reader = csv.DictReader(f)
for row in reader:
shape = [
int(row[f]) if row[f] else None
int(row.get(f)) if row.get(f) else None
for f in ("M", "N", "K", "Bias")
]
shapes.append(shape)
Expand Down
2 changes: 1 addition & 1 deletion torchbenchmark/operators/gemm/operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def triton_tma_persistent_cached_matmul(self, a, b, bias) -> Callable:
def triton_ops_matmul(self, a, b, bias) -> Callable:
if bias is None:
return lambda: kernels.matmul(a, b)
return lambda: kernels.matmul(a, b, bias)
return lambda: kernels.matmul(a, b) + bias

@register_benchmark(baseline=True)
def aten_matmul(self, a, b, bias) -> Callable:
Expand Down
Loading