Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate async_generator #35

Open
pquentin opened this issue Jan 26, 2022 · 5 comments
Open

Deprecate async_generator #35

pquentin opened this issue Jan 26, 2022 · 5 comments

Comments

@pquentin
Copy link
Member

Now that Python 3.6 reached EOL, I believe this library does more harm than good and we should deprecate it and eventually archive it. What do you think?

@geofft
Copy link

geofft commented Feb 5, 2022

I was just about to file an issue asking if you were considering this. I think it'd be worth
a) making the README and the doc home page clear about what async_generator is - something like "async_generator was written as a compatibility library for Python 3.5 to support this and that... it also backports contextlib.asynccontextmanager for Python 3.5 and Python 3.6. If you're on Python 3.7 or newer, you do not need this library at all and should not use it." Right now it kind of dives into the mechanics.
b) removing documentation references in other projects (e.g. https://pytest-trio.readthedocs.io/en/stable/quickstart.html#async-fixtures) to async_generator

and yeah, formally marking it deprecated seems fine. As a data point, the latest NumPy release dropped 3.7 support, so I think you're justified dropping a library that exists mostly for 3.5 and slightly for 3.6 :)

@webknjaz
Copy link
Member

FTR async_generator is experiencing problems under Python 3.11. I didn't look deep into it and removing it and replacing stuff with native syntax helped. (We had it integrated into aiohttp's tests to support Python 3.5 years ago but forgot to drop from some release streams when it was no longer necessary)

@belm0
Copy link
Member

belm0 commented Mar 17, 2023

Now that Python 3.6 reached EOL, I believe this library does more harm than good and we should deprecate it and eventually archive it.

reminder that this library exports aclosing(), which wasn't added until Python 3.10

@opoplawski
Copy link

Tests are failing with Python 3.12. Worth keeping this around or just dumping it?

@jakkdl
Copy link
Member

jakkdl commented Feb 10, 2025

Tests are failing with Python 3.12. Worth keeping this around or just dumping it?

it should probably be kept around for the sake of aclosing() until py310 EOL - but could raise deprecation warnings on everything else in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants