Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typing of chip_erase from bool -> str #1748

Merged
merged 1 commit into from
Feb 23, 2025
Merged

fix typing of chip_erase from bool -> str #1748

merged 1 commit into from
Feb 23, 2025

Conversation

NilsIrl
Copy link

@NilsIrl NilsIrl commented Dec 17, 2024

No description provided.

@ithinuel ithinuel changed the base branch from main to develop February 22, 2025 08:47
ithinuel
ithinuel approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an extra change on loader.py:141.
That’s a good catch. Thank you 👍

@ithinuel
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ithinuel ithinuel merged commit ca5b9e8 into pyocd:develop Feb 23, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ithinuel ithinuel ithinuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NilsIrl @ithinuel