Skip to content

Commit a0b6424

Browse files
author
Jon Elverkilde
authored
Merge pull request #169 from pusher/remove-unused-variables
Removes code related to removed native push notifications
2 parents 8b5fca2 + 725e9c3 commit a0b6424

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

lib/pusher.rb

-2
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ class << self
2828
extend Forwardable
2929

3030
def_delegators :default_client, :scheme, :host, :port, :app_id, :key, :secret, :http_proxy
31-
def_delegators :default_client, :notification_host, :notification_scheme
3231
def_delegators :default_client, :scheme=, :host=, :port=, :app_id=, :key=, :secret=, :http_proxy=
33-
def_delegators :default_client, :notification_host=, :notification_scheme=
3432

3533
def_delegators :default_client, :authentication_token, :url, :cluster
3634
def_delegators :default_client, :encrypted=, :url=, :cluster=

lib/pusher/client.rb

+4-12
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module Pusher
66
class Client
7-
attr_accessor :scheme, :host, :port, :app_id, :key, :secret, :notification_host, :notification_scheme, :encryption_master_key
7+
attr_accessor :scheme, :host, :port, :app_id, :key, :secret, :encryption_master_key
88
attr_reader :http_proxy, :proxy
99
attr_writer :connect_timeout, :send_timeout, :receive_timeout,
1010
:keep_alive_timeout
@@ -45,25 +45,17 @@ def initialize(options = {})
4545
merged_options[:host] = "api.pusherapp.com"
4646
end
4747

48-
# TODO: Change host name when finalized
49-
merged_options[:notification_host] =
50-
options.fetch(:notification_host, "nativepush-cluster1.pusher.com")
51-
52-
merged_options[:notification_scheme] =
53-
options.fetch(:notification_scheme, "https")
54-
55-
@scheme, @host, @port, @app_id, @key, @secret, @notification_host, @notification_scheme =
48+
@scheme, @host, @port, @app_id, @key, @secret =
5649
merged_options.values_at(
57-
:scheme, :host, :port, :app_id, :key, :secret, :notification_host, :notification_scheme
50+
:scheme, :host, :port, :app_id, :key, :secret
5851
)
5952

6053
if options.has_key?(:encryption_master_key_base64)
6154
@encryption_master_key =
6255
Base64.strict_decode64(options[:encryption_master_key_base64])
6356
end
6457

65-
@http_proxy = nil
66-
self.http_proxy = options[:http_proxy] if options[:http_proxy]
58+
@http_proxy = options[:http_proxy]
6759

6860
# Default timeouts
6961
@connect_timeout = 5

0 commit comments

Comments
 (0)