From ed6a595d9bcf5a6fc06ec99988ca7c0107700e7e Mon Sep 17 00:00:00 2001 From: zyc <18611145971@163.com> Date: Fri, 15 Nov 2024 22:14:28 +0800 Subject: [PATCH 1/2] Modify inconsistency between code and comment --- crates/polars-arrow/src/array/primitive/mutable.rs | 2 +- crates/polars-core/src/chunked_array/object/mod.rs | 2 +- crates/polars-parquet/src/parquet/encoding/mod.rs | 2 ++ crates/polars-parquet/src/parquet/encoding/uleb128.rs | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/polars-arrow/src/array/primitive/mutable.rs b/crates/polars-arrow/src/array/primitive/mutable.rs index ab6bfd8c7511..287fe52f0534 100644 --- a/crates/polars-arrow/src/array/primitive/mutable.rs +++ b/crates/polars-arrow/src/array/primitive/mutable.rs @@ -370,7 +370,7 @@ impl MutablePrimitiveArray { /// Sets values. /// # Panic - /// Panics iff the values' length is not equal to the existing validity's len. + /// Panics iff the values' length is not equal to the existing values' len. pub fn set_values(&mut self, values: Vec) { assert_eq!(values.len(), self.values.len()); self.values = values; diff --git a/crates/polars-core/src/chunked_array/object/mod.rs b/crates/polars-core/src/chunked_array/object/mod.rs index 8f4711976856..834f42dc98a6 100644 --- a/crates/polars-core/src/chunked_array/object/mod.rs +++ b/crates/polars-core/src/chunked_array/object/mod.rs @@ -145,7 +145,7 @@ where /// Sets the validity of this array. /// # Panics - /// This function panics iff `values.len() != self.len()`. + /// This function panics iff `validity.len() != self.len()`. #[inline] pub fn set_validity(&mut self, validity: Option) { if matches!(&validity, Some(bitmap) if bitmap.len() != self.len()) { diff --git a/crates/polars-parquet/src/parquet/encoding/mod.rs b/crates/polars-parquet/src/parquet/encoding/mod.rs index eaefc77d64c5..d41ac8c68c4f 100644 --- a/crates/polars-parquet/src/parquet/encoding/mod.rs +++ b/crates/polars-parquet/src/parquet/encoding/mod.rs @@ -8,12 +8,14 @@ pub mod plain_byte_array; pub mod uleb128; pub mod zigzag_leb128; +use polars_utils::index::Bounded; pub use crate::parquet::parquet_bridge::Encoding; /// # Panics /// This function panics iff `values.len() < 4`. #[inline] pub fn get_length(values: &[u8]) -> Option { + assert!(values.len() >= 4); values .get(0..4) .map(|x| u32::from_le_bytes(x.try_into().unwrap()) as usize) diff --git a/crates/polars-parquet/src/parquet/encoding/uleb128.rs b/crates/polars-parquet/src/parquet/encoding/uleb128.rs index 0740c9575a15..ec461075b8a7 100644 --- a/crates/polars-parquet/src/parquet/encoding/uleb128.rs +++ b/crates/polars-parquet/src/parquet/encoding/uleb128.rs @@ -62,6 +62,7 @@ pub fn decode(values: &[u8]) -> (u64, usize) { /// # Panic /// This function may panic if `container.len() < 10` and `value` requires more bytes. pub fn encode(mut value: u64, container: &mut [u8]) -> usize { + assert!(container.len() >= 10); let mut consumed = 0; let mut iter = container.iter_mut(); loop { From 930a057533bb645945a60f011f06826f707f6171 Mon Sep 17 00:00:00 2001 From: zyc <18611145971@163.com> Date: Fri, 15 Nov 2024 22:22:33 +0800 Subject: [PATCH 2/2] Modify inconsistency between code and comment --- crates/polars-parquet/src/parquet/encoding/mod.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/polars-parquet/src/parquet/encoding/mod.rs b/crates/polars-parquet/src/parquet/encoding/mod.rs index d41ac8c68c4f..4e31a44f8c9e 100644 --- a/crates/polars-parquet/src/parquet/encoding/mod.rs +++ b/crates/polars-parquet/src/parquet/encoding/mod.rs @@ -8,7 +8,6 @@ pub mod plain_byte_array; pub mod uleb128; pub mod zigzag_leb128; -use polars_utils::index::Bounded; pub use crate::parquet::parquet_bridge::Encoding; /// # Panics