-
-
Notifications
You must be signed in to change notification settings - Fork 76
/
Copy pathlast_commit.txt
34 lines (22 loc) · 7.17 KB
/
last_commit.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
Repository: plone.restapi
Branch: refs/heads/main
Date: 2025-02-22T10:11:13-08:00
Author: Faakhir Zahid (Faakhir30) <110815427+Faakhir30@users.noreply.github.com>
Commit: https://github.com/plone/plone.restapi/commit/a7d1200cd5188611241355461d4834fedeeb4cc5
Fix status code in GET aliases service (#1881)
* Fix status code in GET aliases
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
* Update news
Co-authored-by: Steve Piercy <web@stevepiercy.com>
---------
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Files changed:
A news/1862.bugfix
M src/plone/restapi/services/aliases/get.py
M src/plone/restapi/tests/http-examples/aliases_get.resp
M src/plone/restapi/tests/http-examples/aliases_root_filter.resp
M src/plone/restapi/tests/http-examples/aliases_root_get.resp
M src/plone/restapi/tests/http-examples/aliases_root_get_csv_format.resp
M src/plone/restapi/tests/test_services_aliases.py
b'diff --git a/news/1862.bugfix b/news/1862.bugfix\nnew file mode 100644\nindex 000000000..9f0c21639\n--- /dev/null\n+++ b/news/1862.bugfix\n@@ -0,0 +1 @@\n+Correct the HTTP response status code to `200 OK` from `201 Create` for the `aliases` GET service. @Faakhir30\n\\ No newline at end of file\ndiff --git a/src/plone/restapi/services/aliases/get.py b/src/plone/restapi/services/aliases/get.py\nindex 3ac3f8121..b07f699ef 100644\n--- a/src/plone/restapi/services/aliases/get.py\n+++ b/src/plone/restapi/services/aliases/get.py\n@@ -26,7 +26,7 @@ def reply_item(self):\n context_path = "/".join(self.context.getPhysicalPath())\n redirects = storage.redirects(context_path)\n aliases = [deroot_path(alias) for alias in redirects]\n- self.request.response.setStatus(201)\n+ self.request.response.setStatus(200)\n self.request.response.setHeader("Content-Type", "application/json")\n return [{"path": alias} for alias in aliases], len(aliases)\n \n@@ -42,7 +42,7 @@ def reply_root(self):\n for redirect in redirects:\n del redirect["redirect"]\n redirect["datetime"] = datetimelike_to_iso(redirect["datetime"])\n- self.request.response.setStatus(201)\n+ self.request.response.setStatus(200)\n \n self.request.form["b_start"] = "0"\n self.request.form["b_size"] = "1000000"\n@@ -61,7 +61,7 @@ def reply_root_csv(self):\n for redirect in redirects:\n del redirect["redirect"]\n redirect["datetime"] = datetimelike_to_iso(redirect["datetime"])\n- self.request.response.setStatus(201)\n+ self.request.response.setStatus(200)\n \n self.request.form["b_start"] = "0"\n self.request.form["b_size"] = "1000000"\ndiff --git a/src/plone/restapi/tests/http-examples/aliases_get.resp b/src/plone/restapi/tests/http-examples/aliases_get.resp\nindex 6e0541929..993f32bbb 100644\n--- a/src/plone/restapi/tests/http-examples/aliases_get.resp\n+++ b/src/plone/restapi/tests/http-examples/aliases_get.resp\n@@ -1,4 +1,4 @@\n-HTTP/1.1 201 Created\n+HTTP/1.1 200 OK\n Content-Type: application/json\n \n {\ndiff --git a/src/plone/restapi/tests/http-examples/aliases_root_filter.resp b/src/plone/restapi/tests/http-examples/aliases_root_filter.resp\nindex fa823e30f..88008b990 100644\n--- a/src/plone/restapi/tests/http-examples/aliases_root_filter.resp\n+++ b/src/plone/restapi/tests/http-examples/aliases_root_filter.resp\n@@ -1,4 +1,4 @@\n-HTTP/1.1 201 Created\n+HTTP/1.1 200 OK\n Content-Type: application/json\n \n {\ndiff --git a/src/plone/restapi/tests/http-examples/aliases_root_get.resp b/src/plone/restapi/tests/http-examples/aliases_root_get.resp\nindex a0ea7e002..3c993f746 100644\n--- a/src/plone/restapi/tests/http-examples/aliases_root_get.resp\n+++ b/src/plone/restapi/tests/http-examples/aliases_root_get.resp\n@@ -1,4 +1,4 @@\n-HTTP/1.1 201 Created\n+HTTP/1.1 200 OK\n Content-Type: application/json\n \n {\ndiff --git a/src/plone/restapi/tests/http-examples/aliases_root_get_csv_format.resp b/src/plone/restapi/tests/http-examples/aliases_root_get_csv_format.resp\nindex 04246f176..d21cbaa0a 100644\n--- a/src/plone/restapi/tests/http-examples/aliases_root_get_csv_format.resp\n+++ b/src/plone/restapi/tests/http-examples/aliases_root_get_csv_format.resp\n@@ -1,4 +1,4 @@\n-HTTP/1.1 201 Created\n+HTTP/1.1 200 OK\n Content-Type: text/csv; charset=utf-8\n \n old path,new path,datetime,manual\r\ndiff --git a/src/plone/restapi/tests/test_services_aliases.py b/src/plone/restapi/tests/test_services_aliases.py\nindex 27e4ca693..d8038fe3e 100644\n--- a/src/plone/restapi/tests/test_services_aliases.py\n+++ b/src/plone/restapi/tests/test_services_aliases.py\n@@ -44,7 +44,7 @@ def test_alias_non_root(self):\n \n # Verify alias exists\n response = self.api_session.get("/front-page/@aliases")\n- self.assertEqual(response.status_code, 201)\n+ self.assertEqual(response.status_code, 200)\n self.assertEqual(len(response.json()["items"]), 1)\n \n def test_alias_add_invalid_datetime(self):\n@@ -66,7 +66,7 @@ def test_alias_add_invalid_datetime(self):\n response = self.api_session.post("/@aliases", json=data)\n self.assertEqual(response.status_code, 204)\n response = self.api_session.get("/@aliases")\n- self.assertEqual(response.status_code, 201)\n+ self.assertEqual(response.status_code, 200)\n self.assertEqual(len(response.json()["items"]), 2)\n \n def test_alias_add_invalid_path(self):\n@@ -76,7 +76,7 @@ def test_alias_add_invalid_path(self):\n response = self.api_session.post("/@aliases", json=data)\n self.assertEqual(response.status_code, 400)\n response = self.api_session.get("/@aliases")\n- self.assertEqual(response.status_code, 201)\n+ self.assertEqual(response.status_code, 200)\n self.assertEqual(len(response.json()["items"]), 0)\n \n def test_duplicate_alias(self):\n@@ -108,7 +108,7 @@ def test_alias_csv_upload(self):\n self.assertEqual(response.status_code, 204)\n self.assertEqual(response.content, b"")\n response = self.api_session.get("/@aliases")\n- self.assertEqual(response.status_code, 201)\n+ self.assertEqual(response.status_code, 200)\n self.assertEqual(\n response.json().get("items"),\n [\n@@ -136,7 +136,7 @@ def test_alias_csv_download(self):\n self.api_session.post("/@aliases", json=data)\n headers = {"Accept": "text/csv"}\n response = self.api_session.get("/@aliases", headers=headers)\n- self.assertEqual(response.status_code, 201)\n+ self.assertEqual(response.status_code, 200)\n self.assertIn("Content-Disposition", response.headers)\n self.assertEqual(response.headers["Content-Type"], "text/csv; charset=utf-8")\n content = b"old path,new path,datetime,manual\\r\\n/alias-page,/front-page,2022/01/01 00:00:00 GMT+0,True\\r\\n"\n@@ -158,5 +158,5 @@ def test_alias_delete(self):\n self.assertEqual(response.status_code, 204)\n \n response = self.api_session.get("/@aliases")\n- self.assertEqual(response.status_code, 201)\n+ self.assertEqual(response.status_code, 200)\n self.assertEqual(len(response.json()["items"]), 0)\n'