Permit the '@' character in filenames #684
Conversation
floppym
force-pushed
the
banned-character-filesdir
branch
2 times, most recently
from
a98b422 to
5efad2d
Compare
|
The charset in the repo is based on the POSIX Portable Filename Character Set, with the addition of the plus sign. IIRC this was discussed in QA at some point because there were files with problematic characters like https://devmanual.gentoo.org/general-concepts/tree/index.html#what-belongs-in-the-tree |
As I have said before, that character set is overly restrictive. It excludes many characters that work just fine on the platforms Gentoo targets.
The line "Files whose name contains characters outside [A-Za-z0-9._+-]" was added to the devmanual by you in this commit. https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=57f7cae438731c26130d8f45e12572e727185189 It references the "status quo", not any QA decision. |
floppym
force-pushed
the
banned-character-filesdir
branch
3 times, most recently
from
5621778 to
4526684
Compare
floppym
changed the title
floppym
changed the title
To clarify, not necessarily an official QA decision, but it was discussed. I certainly didn't add that bullet point without getting consensus. At the time it was also a no-brainer because a) it reflected the status of the tree, and b) the rationale for the POSIX charset was that it was already mentioned elsewhere in the devmanual (this has been there since 2005, in ciaranm's RST version). So, not much thought was given to addition of other characters. |
This will allow for systemd template units to be stored in files/ without mangling the filename. Signed-off-by: Mike Gilbert <floppym@gentoo.org>
floppym
force-pushed
the
banned-character-filesdir
branch
from
4526684 to
dafbba6
Compare
floppym
changed the title
Yeah, I get triggered by undocumented QA decisions. I'm sure it was discussed by some people, but without a record of it I have no context. In the interest of keeping things simple/consistent, I added '@' to the existing set of permitted characters and dropped the separate set specific to files/. If that is undesirable, I can revert back. |
|
Also for the purposes of documentation, this devmanual PR was merged today. gentoo/devmanual#339 |
|
Should the git hook allow |
|
I'm giving up on this for now. This QA check is coded in too many places and I'm just too frustrated at this point. |
This will allow for systemd template units to be stored in files/ without mangling the filename.
PMS says nothing about filenames in files/ so we can really permit whatever we find palatable.