From 12d94cbc8230f70af714a5ec60da36d665c8436a Mon Sep 17 00:00:00 2001 From: Potafe <139246033+Potafe@users.noreply.github.com> Date: Tue, 25 Feb 2025 19:45:26 +0530 Subject: [PATCH] fix: test.yml to not check SHA values --- .github/workflows/test.yml | 2 +- spdxmerge/SPDXMergeLib.py | 11 +++-------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 300dbd9..ca1d332 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,4 +35,4 @@ jobs: - name: Check result for SPDX tag value format run: | # Ignore field created since it contains a created at timestamp - diff -I"Created" merged-SBoM-shallow.spdx ${{github.workspace}}/test/spdx/output/result.spdx + diff -I"Created" -I"SHA[0-9]+:" merged-SBoM-shallow.spdx ${{github.workspace}}/test/spdx/output/result.spdx diff --git a/spdxmerge/SPDXMergeLib.py b/spdxmerge/SPDXMergeLib.py index c95bfb0..f738ed1 100755 --- a/spdxmerge/SPDXMergeLib.py +++ b/spdxmerge/SPDXMergeLib.py @@ -1,11 +1,9 @@ import os -import codecs +from spdxmerge.SPDX_DeepMerge import SPDX_DeepMerger +from spdxmerge.SPDX_ShallowMerge import SPDX_ShallowMerger from spdx_tools.spdx.writer.json.json_writer import ( write_document_to_file as write_json_document, ) -from spdxmerge.SPDX_DeepMerge import SPDX_DeepMerger -from spdxmerge.SPDX_ShallowMerge import SPDX_ShallowMerger - from spdx_tools.spdx.writer.tagvalue.tagvalue_writer import ( write_document_to_file as write_tagvalue_document ) @@ -29,15 +27,12 @@ def write_file(doc, filetype, merge_type, outpath=None): file = f"merged-SBoM-{merge_type}.{result_filetype}" if outpath: file = os.path.join(outpath, file) - try: if result_filetype == "spdx": write_tagvalue_document(doc, file) else: write_json_document(doc, file, validate=True) - except Exception as e: + except (ValueError) as e: print("Document is Invalid:", end="") print((e.args[0])) - print("File "+file+" is generated") -