Remove unused codepath

Signed-off-by: Peter Nied <petern@amazon.com>

Author: peternied

server/src/internalClusterTest/java/org/opensearch/action/admin/indices/view/ViewTestBase.java

@@ -57,7 +57,7 @@ protected List<String> listViewNames() {
     }
 
     protected SearchResponse searchView(final String viewName) throws Exception {
-        final SearchViewAction.Request request = SearchViewAction.createRequestWith(viewName, new SearchRequest());
+        final SearchViewAction.Request request = new SearchViewAction.Request(viewName, new SearchRequest());
         final SearchResponse response = client().searchView(request).actionGet();
         return response;
     }

server/src/main/java/org/opensearch/action/admin/indices/view/SearchViewAction.java

@@ -16,10 +16,8 @@
 import org.opensearch.action.support.HandledTransportAction;
 import org.opensearch.common.annotation.ExperimentalApi;
 import org.opensearch.common.inject.Inject;
-import org.opensearch.common.io.stream.BytesStreamOutput;
 import org.opensearch.core.action.ActionListener;
 import org.opensearch.core.common.Strings;
-import org.opensearch.core.common.io.stream.BytesStreamInput;
 import org.opensearch.core.common.io.stream.StreamInput;
 import org.opensearch.core.common.io.stream.StreamOutput;
 import org.opensearch.tasks.Task;
@@ -42,16 +40,6 @@ private SearchViewAction() {
         super(NAME, SearchResponse::new);
     }
 
-    /** Given a search request, creates a ViewSearchRequest */
-    public static Request createRequestWith(final String view, final SearchRequest searchRequest) throws IOException {
-        final BytesStreamOutput savedSearchRequest = new BytesStreamOutput();
-        searchRequest.writeTo(savedSearchRequest);
-        savedSearchRequest.writeString(view);
-
-        final BytesStreamInput input = new BytesStreamInput(savedSearchRequest.bytes().toBytesRef().bytes);
-        return new Request(input);
-    }
-
     /**
      * Wraps the functionality of search requests and tailors for what is available
      * when searching through views

server/src/test/java/org/opensearch/action/admin/indices/view/SearchViewRequestTests.java

@@ -30,14 +30,14 @@ protected Writeable.Reader<SearchViewAction.Request> instanceReader() {
     @Override
     protected SearchViewAction.Request createTestInstance() {
         try {
-            return SearchViewAction.createRequestWith(randomAlphaOfLength(8), new SearchRequest());
+            return new SearchViewAction.Request(randomAlphaOfLength(8), new SearchRequest());
         } catch (final Exception e) {
             throw new RuntimeException(e);
         }
     }
 
     public void testValidateRequest() throws IOException {
-        final SearchViewAction.Request request = SearchViewAction.createRequestWith("my-view", new SearchRequest());
+        final SearchViewAction.Request request = new SearchViewAction.Request("my-view", new SearchRequest());
         MatcherAssert.assertThat(request.validate(), nullValue());
     }