Skip to content

Commit c8bc3bd

Browse files
committed
Make a breaking change
Signed-off-by: Peter Nied <petern@amazon.com>
1 parent 6ce041e commit c8bc3bd

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

server/src/main/java/org/opensearch/plugins/Plugin.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,12 @@ protected Optional<String> getFeature() {
104104
return Optional.empty();
105105
}
106106

107-
/**
108-
* Node level guice modules.
109-
*/
110-
public Collection<Module> createGuiceModules() {
111-
return Collections.emptyList();
112-
}
107+
// /**
108+
// * Node level guice modules.
109+
// */
110+
// public Collection<Module> createGuiceModules() {
111+
// return Collections.emptyList();
112+
// }
113113

114114
/**
115115
* Node level services that will be automatically started/stopped/closed. This classes must be constructed

server/src/main/java/org/opensearch/plugins/PluginsService.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ public Settings updatedSettings() {
283283
public Collection<Module> createGuiceModules() {
284284
List<Module> modules = new ArrayList<>();
285285
for (Tuple<PluginInfo, Plugin> plugin : plugins) {
286-
modules.addAll(plugin.v2().createGuiceModules());
286+
// modules.addAll(plugin.v2().createGuiceModules());
287287
}
288288
return modules;
289289
}

0 commit comments

Comments
 (0)