Detact metadataFilesEligibleToDelete from its source collection

Signed-off-by: Peter Nied <peternied@hotmail.com>

Author: peternied

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java

@@ -745,10 +745,10 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException
             return;
         }
 
-        List<String> metadataFilesEligibleToDelete = sortedMetadataFileList.subList(
+        List<String> metadataFilesEligibleToDelete = new ArrayList<>(sortedMetadataFileList.subList(
             lastNMetadataFilesToKeep,
             sortedMetadataFileList.size()
-        );
+        ));
         Set<String> allLockFiles;
         try {
             allLockFiles = ((RemoteStoreMetadataLockManager) mdLockManager).fetchLockedMetadataFiles(MetadataFilenameUtils.METADATA_PREFIX);
@@ -764,7 +764,7 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException
         logger.debug(
             "metadataFilesEligibleToDelete={} metadataFilesToBeDeleted={}",
             metadataFilesEligibleToDelete,
-            metadataFilesEligibleToDelete
+            metadataFilesToBeDeleted
         );
 
         Map<String, UploadedSegmentMetadata> activeSegmentFilesMetadataMap = new HashMap<>();