PR feedback pass

Signed-off-by: Peter Nied <petern@amazon.com>

Author: peternied

server/src/main/java/org/opensearch/action/admin/indices/view/ViewService.java

@@ -23,6 +23,7 @@
 import org.opensearch.common.annotation.ExperimentalApi;
 import org.opensearch.core.action.ActionListener;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
@@ -36,7 +37,7 @@ public class ViewService {
     private final static Logger LOG = LogManager.getLogger(ViewService.class);
     private final ClusterService clusterService;
     private final NodeClient client;
-    private LongSupplier timeProvider;
+    private final LongSupplier timeProvider;
 
     public ViewService(final ClusterService clusterService, final NodeClient client, final LongSupplier timeProvider) {
         this.clusterService = clusterService;
@@ -69,7 +70,6 @@ public void updateView(final CreateViewAction.Request request, final ActionListe
         createOrUpdateView(Operation.UpdateView, updatedView, listener);
     }
 
-    @SuppressWarnings("deprecation")
     public void deleteView(final DeleteViewAction.Request request, final ActionListener<AcknowledgedResponse> listener) {
         getViewOrThrowException(request.getName());
 
@@ -101,14 +101,12 @@ public void getView(final GetViewAction.Request request, final ActionListener<Ge
     }
 
     public void listViewNames(final ActionListener<ListViewNamesAction.Response> listener) {
-        final List<String> viewNames = Optional.ofNullable(clusterService)
+        final List<String> viewNames = new ArrayList<>(Optional.ofNullable(clusterService)
             .map(ClusterService::state)
             .map(ClusterState::metadata)
             .map(Metadata::views)
             .map(Map::keySet)
-            .orElseThrow()
-            .stream()
-            .collect(Collectors.toList());
+            .orElseThrow());
 
         listener.onResponse(new ListViewNamesAction.Response(viewNames));
     }
@@ -119,8 +117,7 @@ public void searchView(final SearchViewAction.Request request, final ActionListe
         final String[] indices = view.getTargets()
             .stream()
             .map(View.Target::getIndexPattern)
-            .collect(Collectors.toList())
-            .toArray(new String[0]);
+            .toArray(String[]::new);
         request.indices(indices);
 
         client.executeLocally(SearchAction.INSTANCE, request, listener);
@@ -130,7 +127,7 @@ View getViewOrThrowException(final String viewName) {
         return Optional.ofNullable(clusterService)
             .map(ClusterService::state)
             .map(ClusterState::metadata)
-            .map(m -> m.views())
+            .map(Metadata::views)
             .map(views -> views.get(viewName))
             .orElseThrow(() -> new ResourceNotFoundException("View [" + viewName + "] does not exist"));
     }
@@ -141,7 +138,7 @@ private enum Operation {
 
         private final String name;
 
-        private Operation(final String name) {
+        Operation(final String name) {
             this.name = name;
         }
     }

server/src/main/java/org/opensearch/cluster/metadata/View.java

@@ -43,7 +43,7 @@ public View(final String name, final String description, final Long createdAt, f
     }
 
     public View(final StreamInput in) throws IOException {
-        this(in.readString(), in.readOptionalString(), in.readVLong(), in.readVLong(), in.readList(Target::new));
+        this(in.readString(), in.readOptionalString(), in.readZLong(), in.readZLong(), in.readList(Target::new));
     }
 
     public String getName() {
@@ -186,8 +186,8 @@ public XContentBuilder toXContent(final XContentBuilder builder, final Params pa
     public void writeTo(final StreamOutput out) throws IOException {
         out.writeString(name);
         out.writeOptionalString(description);
-        out.writeVLong(createdAt);
-        out.writeVLong(modifiedAt);
+        out.writeZLong(createdAt);
+        out.writeZLong(modifiedAt);
         out.writeList(targets);
     }
 }