Skip to content

Commit d8cac2f

Browse files
pedroerpfacebook-github-bot
authored andcommitted
fix(python): Remove .pyi annotations (facebookincubator#12314)
Summary: Pull Request resolved: facebookincubator#12314 Removing .pyi annotations by properly setting interface includes and dependencies. Reviewed By: kevinwilfong Differential Revision: D69538934 fbshipit-source-id: 9f9608741e5e16e49e9138021749752f5f292442
1 parent e14fc1d commit d8cac2f

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

velox/py/arrow/arrow.pyi

-2
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@
1818

1919
from typing import List
2020

21-
# pyre-fixme[21]: Could not find `velox.py.vector`.
2221
from velox.py.vector import Vector
2322
from pyarrow import Array
2423

25-
# pyre-fixme[11]: Annotation `Vector` is not defined as a type.
2624
def to_velox(array: Array) -> Vector: ...
2725
def to_arrow(vector: Vector) -> Array: ...

velox/py/plan_builder/plan_builder.pyi

+1-6
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@
1919
from enum import Enum
2020
from typing import List, Dict, Type
2121

22-
# pyre-fixme[21]: Could not find `velox.py.type`.
23-
from velox.py.type import Type
24-
25-
# pyre-fixme[21]: Could not find `velox.py.type`.
2622
from velox.py.file import File
23+
from velox.py.type import Type
2724

2825

2926
class JoinType(Enum):
@@ -37,13 +34,11 @@ class PlanBuilder:
3734
def __init__(self) -> None: ...
3835
def table_scan(
3936
self,
40-
# pyre-fixme[11]: Annotation `Type` is not defined as a type.
4137
output_schema: Type,
4238
aliases: Dict[str, str] = {},
4339
subfields: Dict[str, List[int]] = {},
4440
row_index: str = "",
4541
connector_id: str = "prism",
46-
# pyre-fixme[11]: Annotation `File` is not defined as a type.
4742
input_files: List[File] = [],
4843
) -> PlanBuilder: ...
4944
def get_plan_node(self) -> PlanBuilder: ...

velox/py/runner/runner.pyi

+1-3
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,11 @@
1818

1919
from typing import Iterator
2020

21-
# pyre-fixme[21]: Could not find `velox.py.type`.
22-
from velox.py.cector import Vector
21+
from velox.py.vector import Vector
2322

2423

2524
class LocalRunner:
2625
def __init__(self, PlanNode) -> None: ...
27-
# pyre-fixme[11]: Annotation `Vector` is not defined as a type.
2826
def execute(self) -> Iterator[Vector]: ...
2927
def add_file_split(self, plan_id: str, file_path: str) -> None: ...
3028

0 commit comments

Comments
 (0)