Skip to content

Commit 762b9c1

Browse files
kgpaifacebook-github-bot
authored andcommitted
fix(builds): Fix nightly build metrics job to add shared builds (facebookincubator#12088)
Summary: Adding assignUser 's new shared build hotness to the nightly build metrics. This will change the old debug/release names to have names like shared-debug, static-debug so we can differentiate on type of build used. After merge and subsequent nightly run we should see the metrics here : https://facebookincubator.github.io/velox/bm-report/ Pull Request resolved: facebookincubator#12088 Reviewed By: kagamiori Differential Revision: D68186465 Pulled By: kgpai fbshipit-source-id: 8c845facf3b5e86fb9ffaaf0d9c453b4ed441187
1 parent f48c904 commit 762b9c1

File tree

1 file changed

+24
-3
lines changed

1 file changed

+24
-3
lines changed

.github/workflows/build-metrics.yml

+24-3
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
matrix:
4545
runner: ["16-core-ubuntu"]
4646
type: ["debug", "release"]
47+
link-type: ["shared", "static"]
4748
defaults:
4849
run:
4950
shell: bash
@@ -57,7 +58,8 @@ jobs:
5758
# it doesn't work
5859
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}
5960

60-
- name: Make ${{ matrix.type }} Build
61+
- name: Make ${{ matrix.link-type }} - ${{ matrix.type }} Build
62+
if: ${{ matrix.link-type == 'static' }}
6163
env:
6264
MAKEFLAGS: 'MAX_HIGH_MEM_JOBS=8 MAX_LINK_JOBS=4'
6365
run: |
@@ -73,6 +75,25 @@ jobs:
7375
)
7476
make '${{ matrix.type }}'
7577
78+
- name: Make ${{ matrix.link-type }} - ${{ matrix.type }} Build
79+
if: ${{ matrix.link-type == 'shared' }}
80+
env:
81+
MAKEFLAGS: 'MAX_HIGH_MEM_JOBS=8 MAX_LINK_JOBS=4'
82+
run: |
83+
EXTRA_CMAKE_FLAGS=(
84+
"-DVELOX_ENABLE_BENCHMARKS=ON"
85+
"-DVELOX_ENABLE_ARROW=ON"
86+
"-DVELOX_ENABLE_PARQUET=ON"
87+
"-DVELOX_ENABLE_HDFS=ON"
88+
"-DVELOX_ENABLE_S3=ON"
89+
"-DVELOX_ENABLE_GCS=ON"
90+
"-DVELOX_ENABLE_ABFS=ON"
91+
"-DVELOX_ENABLE_REMOTE_FUNCTIONS=ON"
92+
"-DVELOX_MONO_LIBRARY=ON"
93+
"-DVELOX_BUILD_SHARED=ON"
94+
)
95+
make '${{ matrix.type }}'
96+
7697
- name: Log binary sizes
7798
run: |
7899
mkdir -p /tmp/metrics
@@ -110,8 +131,8 @@ jobs:
110131
CONBENCH_PROJECT_COMMIT: "${{ inputs.ref || github.sha }}"
111132
run: |
112133
./scripts/build-metrics.py upload \
113-
--build_type "${{ matrix.type }}" \
114-
--run_id "BM-${{ matrix.type }}-${{ github.run_id }}-${{ github.run_attempt }}" \
134+
--build_type "${{ matrix.link-type }}-${{ matrix.type }}" \
135+
--run_id "BM-${{ matrix.link-type }}-${{ matrix.type }}-${{ github.run_id }}-${{ github.run_attempt }}" \
115136
--pr_number "${{ github.event.number }}" \
116137
--sha "${{ inputs.ref || github.sha }}" \
117138
"/tmp/metrics"

0 commit comments

Comments
 (0)